github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1691] [MERGED] [refactor] Migrate Schedules Table to typescript #3902

New Issue
Closed
opened 2026-02-28 20:48:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:48:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1691
Author: @muhsinkamil
Created: 9/12/2023
Status: ✅ Merged
Merged: 9/17/2023
Merged by: @MatissJanis

Base: master ← Head: refactor/1483-schedules-table

📝 Commits (10+)

  • 23fad8c refactor: change schedules table to ts file
  • 95382b3 refactor: add generic types to table component
  • 3e09fe1 refactor: add types to cached accounts & payees
  • d2b6b3f refactor: add types and refactor StatusBadge file
  • 6407807 refactor: add types to table component ref
  • 20dd857 refactor: change colors to themes
  • 025c0b8 chore: add release note
  • 23ed104 refactor: add types to Schedule item actions
  • 7649afe refactor: type with Item action enum for onAction in SchedulesTable
  • b991f67 refactor: add types to schedules date

📊 Changes

11 files changed (+256 additions, -161 deletions)

View changed files

📝 packages/desktop-client/src/components/common/Menu.tsx (+1 -1)
📝 packages/desktop-client/src/components/schedules/SchedulesTable.tsx (+126 -61)
📝 packages/desktop-client/src/components/schedules/StatusBadge.tsx (+52 -60)
📝 packages/desktop-client/src/components/schedules/index.tsx (+6 -6)
📝 packages/desktop-client/src/components/table.tsx (+11 -6)
📝 packages/loot-core/src/client/data-hooks/accounts.tsx (+13 -6)
📝 packages/loot-core/src/client/data-hooks/payees.tsx (+13 -6)
📝 packages/loot-core/src/client/data-hooks/schedules.tsx (+12 -9)
📝 packages/loot-core/src/shared/util.ts (+1 -1)
📝 packages/loot-core/src/types/models/schedule.d.ts (+15 -5)
➕ upcoming-release-notes/1691.md (+6 -0)

📄 Description

Relates to https://github.com/actualbudget/actual/issues/1483

  • Migrate Schedules Table and its child components to ts

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1691 **Author:** [@muhsinkamil](https://github.com/muhsinkamil) **Created:** 9/12/2023 **Status:** ✅ Merged **Merged:** 9/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `refactor/1483-schedules-table` --- ### 📝 Commits (10+) - [`23fad8c`](https://github.com/actualbudget/actual/commit/23fad8ca80d6649cffac4683fc6a85dea7e8eea2) refactor: change schedules table to ts file - [`95382b3`](https://github.com/actualbudget/actual/commit/95382b3c2f5f81382c7bda433026eef99b3c5922) refactor: add generic types to table component - [`3e09fe1`](https://github.com/actualbudget/actual/commit/3e09fe137a6ea10503c684e5619a9ad4363cd5a4) refactor: add types to cached accounts & payees - [`d2b6b3f`](https://github.com/actualbudget/actual/commit/d2b6b3f3fefc77a32500eb047c193632a969cd5d) refactor: add types and refactor StatusBadge file - [`6407807`](https://github.com/actualbudget/actual/commit/6407807bf3a1d15e4c6bda1ab23f65334fb0f1ad) refactor: add types to table component ref - [`20dd857`](https://github.com/actualbudget/actual/commit/20dd8577e314d3dbb0761bf6ed2b37c7010dff83) refactor: change colors to themes - [`025c0b8`](https://github.com/actualbudget/actual/commit/025c0b888063a68f1162e06dcf925e27dddd2b12) chore: add release note - [`23ed104`](https://github.com/actualbudget/actual/commit/23ed104c812e68a1bb41f5e32014c4f8931be570) refactor: add types to Schedule item actions - [`7649afe`](https://github.com/actualbudget/actual/commit/7649afe8cdbc7559284b43cc313b548421cf267e) refactor: type with Item action enum for onAction in SchedulesTable - [`b991f67`](https://github.com/actualbudget/actual/commit/b991f677bad003fd64ef70357e3bd43f3058981a) refactor: add types to schedules date ### 📊 Changes **11 files changed** (+256 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/common/Menu.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/schedules/SchedulesTable.tsx` (+126 -61) 📝 `packages/desktop-client/src/components/schedules/StatusBadge.tsx` (+52 -60) 📝 `packages/desktop-client/src/components/schedules/index.tsx` (+6 -6) 📝 `packages/desktop-client/src/components/table.tsx` (+11 -6) 📝 `packages/loot-core/src/client/data-hooks/accounts.tsx` (+13 -6) 📝 `packages/loot-core/src/client/data-hooks/payees.tsx` (+13 -6) 📝 `packages/loot-core/src/client/data-hooks/schedules.tsx` (+12 -9) 📝 `packages/loot-core/src/shared/util.ts` (+1 -1) 📝 `packages/loot-core/src/types/models/schedule.d.ts` (+15 -5) ➕ `upcoming-release-notes/1691.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Relates to https://github.com/actualbudget/actual/issues/1483 - [x] Migrate Schedules Table and its child components to ts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:48:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3902
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?