* [AI] Fix SimpleFin batch sync crash when accounts are missing from response
When SimpleFin doesn't return data for all requested accounts during
batch sync, the code crashed with a TypeError accessing properties on
undefined, resulting in a generic "internal error" message for users.
This fix:
- Adds a guard in simpleFinBatchSync for missing account data, returning
an ACCOUNT_MISSING error instead of crashing
- Propagates error entries from the SimpleFin response's errors map for
accounts that have no data entry
- Adds a user-friendly ACCOUNT_MISSING error message in the UI suggesting
to unlink and relink the account
- Adds test cases covering both scenarios
https://claude.ai/code/session_01XbHgxxrXYR3UTyW6VmYj47
* Add release notes for PR #7152
* [AI] Fix SimpleFIN batch sync error_code TypeError
Fix "Cannot read properties of undefined (reading 'error_code')" that
occurs during SimpleFIN batch sync by:
1. Adding null check for downloadSimpleFinTransactions result in
simpleFinBatchSync (sync.ts) - the function can return undefined
when user token is missing
2. Adding .catch() handler on individual processBankSyncDownload
promises so a single account failure doesn't crash the entire
batch via Promise.all rejection
3. Using optional chaining on syncResponse.res?.error_code in app.ts
and handling the case where res is undefined with proper error
reporting
https://claude.ai/code/session_01XbHgxxrXYR3UTyW6VmYj47
* [AI] Fix SimpleFin batch sync to emit ACCOUNT_MISSING for empty payloads
In the batch sync path, if a per-account download payload is an empty
object or is missing the transactions array, processBankSyncDownload
would crash and the error would be caught as INTERNAL_ERROR. Now we
check for these cases explicitly and emit ACCOUNT_MISSING instead,
while still allowing entries with error_code to propagate their
specific error.
https://claude.ai/code/session_01XbHgxxrXYR3UTyW6VmYj47
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [AI] Consolidate custom theme prefs and improve auto-mode UX
- Merge `installedCustomTheme` into `installedCustomLightTheme` so only
two prefs exist (light + dark). The legacy asyncStorage key
`installed-custom-theme` is preserved for backwards compatibility.
- In auto (System default) mode, the main Theme dropdown no longer
surfaces the installed custom-light theme as an option; custom themes
for light/dark are managed exclusively via the sub-selectors.
- Selecting "System default" resets both light and dark custom themes.
- Installing a custom theme from the main dropdown while in auto mode
switches the base theme to "Light" so it applies directly.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add release notes for PR #7145
* Change category from Features to Enhancement
Custom Themes: separate light and dark theme options when selecting 'system default' theme.
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #7145
* Enhance ThemeSettings and UI components by adding maxWidth styling for better responsiveness. This change ensures that buttons and columns adapt to the full width of their containers.
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update Titlebar.tsx sync name to Server Sync
* Update Titlebar.tsx
* Create 7005.md
Change title Bar 'Sync' to 'Server Sync'.
* Update packages/desktop-client/src/components/Titlebar.tsx
Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
* Update packages/desktop-client/src/components/Titlebar.tsx
Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
* Update Titlebar.tsx
* Update Titlebar.tsx
* Update Titlebar.tsx
* [autofix.ci] apply automated fixes
* Update 7005.md
* Disable Server Sync button when offline in Titlebar component
* fix lint
* Add aria-disabled attribute to Server Sync button in Titlebar component
* Update titlebar sync icon and improve accessibility
Add disabled state and aria disabled label for offline mode.
---------
Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: youngcw <calebyoung94@gmail.com>
* Add "only import transactions since"
If specified, we filter out transactions before the given date.
* Address 🐰 comments
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #7139
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Phase 1: Add payee locations database schema/types
* Add migration to create payee_locations table with proper indexes
* Add PayeeLocationEntity type definition
* Update database schema to include payee_locations table
* Export PayeeLocationEntity from models index
* Phase 2: Add payee location API/services
* Add constants for default location behavior
* Implement location service with geolocation adapters
* Add new API handlers for payee location operations
* Phase 3: Add location-aware UI components/hooks
* Update mobile transaction editing with location integration
* Enhance PayeeAutocomplete with nearby payee suggestions and forget
functionality
* Implement location permission and placeholder unit of measurement hooks
* Phase 4: Add YNAB5 payee location import support
* Extend YNAB5 types to include location data from payees
* Implement location import logic in YNAB5 importer
* Phase 5: Add unit of measurement support
* Add unit of measurement preference setting in Format.tsx
* Implement distance formatting utilities for imperial/metric units
* Add useUnitOfMeasurementFormat hook for accessing preferences
* Required release note about the PR
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #6157
* Actually get syncing working
This was not obvious to me, esp. with 13 years of data, but the
locations I've been inserting were local only.
Everything appeared to work.
What I failed to notice is that the locations did not sync
across devices. Of course all the location data that was imported worked
fine, but nothing new unless it was created on device.
This changes the schema and uses the proper insert/delete methods such
that syncing works.
* Remove unit of measurement preference
Display feet and meters automatically, and don't bother to format based on miles/kilometers.
* Add payeeLocations feature flag
Place the location permissions check and thus user-facing functionality behind the feature flag
* Missed adding tombstone to payee location query
* Adjust migration name to pass CI
Adjust the indexes as well
* Unify location.ts
If CodeRabbit complains again, reply that we are actively choosing a unified file
* Add bounds testing
The validation is straightforward range-checking — if it's wrong, it'll be obvious quickly. Unless there's a plan to start adding broader test coverage for that file, I'd leave it untested for now
* Prefer camelCase for the method params
* Fix the nested interactive containers
* Fix the majority of CodeRabbit nits
The remainder seem to not be related to my code change (just a lint), outdated (sql migration comment), or infeasible (sql haversine query)
* More CodeRabbit nits
* Revert unnecessary YNAB5 zip import
Turns out the payee_locations were inside the exported budget all along!
* Additional guards and other CR fixes
* Match the pattern used elsewhere in file
* YNAB5.Budget -> Budget
Missed in the merge conflict
* ci: trigger rerun
* Change import from fetch to connection module
* Correct invalid border property
Ah. I never noticed this property wasn't working. I guess the button
looked OK to me!
* Only hide the button on success
* Update packages/loot-core/src/shared/location-utils.ts
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
* Update packages/loot-core/src/server/payees/app.ts
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
* Fully fix typo
Guess I shouldn't commit a suggestion after waking up
* Attempting to address feedback
Manual select nearby payee and save payee location buttons to make the UX more obvi
* Remove stale file that was moved
* Additional cleanup of remnant change
Removed the references to location from a few existing entities
* Additional cleanup of remnant change
* Show the Nearby payees button even when the field is disabled
If there are nearby payees, there's not a payee already selected, and the save button isn't needed
* runQuery is not async
* Add mockNearbyPayeesResult to test
Trying to utilize the real type in the mock
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv>
* Add failing tests for SimpleFin batch sync shared error array bug
Tests prove two bugs in simpleFinBatchSync() catch block (app.ts:1100-1115):
1. All accounts share the same errors array reference
2. Errors accumulate across accounts instead of being isolated
Related: #6623, #6651, #7114https://claude.ai/code/session_011ebiiXRMmbiKxYMohVXL6o
* Fix shared error array in SimpleFin batch sync catch block
When simpleFinBatchSync() threw an error, all accounts received the
same errors array by reference and errors accumulated across accounts.
Each account now gets its own isolated errors array with a single error
specific to that account, matching the pattern used by accountsBankSync().
Fixes#6623https://claude.ai/code/session_011ebiiXRMmbiKxYMohVXL6o
* Remove @ts-strict-ignore from bank sync tests
Use proper non-null assertions instead of disabling strict mode.
https://claude.ai/code/session_011ebiiXRMmbiKxYMohVXL6o
* Add release notes for PR #7125
* [AI] Replace test() with it() to follow repo convention
Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com>
* [AI] Extract PR/commit rules into shared agent skill
Deduplicate PR and commit instructions from AGENTS.md into a standalone
skill file at .github/agents/pr-and-commit-rules.md. This single source
of truth is consumed by both Claude Code (via CLAUDE.md @-import) and
Cursor (via .cursor/rules/pr-and-commit.mdc with alwaysApply: true).
AGENTS.md now references the shared file instead of repeating the rules
in three separate sections.
https://claude.ai/code/session_01KkHg7MYXrTyDkTw6u98Vam
* Add release notes for PR #7153
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update amount styling with theme colors
* Clean up imports in TransactionListItem.tsx
Removed unused import of makeBalanceAmountStyle.
* Add release notes for bugfix in color variables
Fix color variables for mobile transaction list items.
* Change positiveColor in amount to use theme.tableText
* Change negative color style for running balance
* Fix negative color style in TransactionListItem
* Update color styles for transaction amount display
* Update upcoming-release-notes/7047.md
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
* Update VRT screenshots
Auto-generated by VRT workflow
PR: #7047
---------
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix(csv-import): trim whitespace from amount strings before parsing
looselyParseAmount relies on a regex anchored at $ to detect decimal
markers. Trailing whitespace (e.g. from Excel-saved CSVs) shifts the
pattern match so a thousands separator is misidentified as a decimal
point, producing wildly wrong values.
Adding trim() at the top of the function eliminates trailing/leading
whitespace before any regex logic runs.
Fixes actualbudget/actual#7121
* chore: add release notes for #7149
* [AI] Sort custom theme catalog options alphabetically in the UI
Sort catalog themes by name using localeCompare before rendering,
without modifying the underlying JSON data file.
https://claude.ai/code/session_01Y5SGaVYqsVWVsvXV8ZFXj3
* Add release notes for PR #7144
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [AI] Remove parent path import of window.ts from desktop-client tsconfig
Replace the `../../packages/loot-core/typings/window.ts` include in
desktop-client's tsconfig.json with a proper package import. This adds
a `./typings/*` export to loot-core's package.json and creates a
globals.ts file in desktop-client that imports the window types via
the package name.
https://claude.ai/code/session_01GrgAzjWd3XvqwBTfXLerxc
* [autofix.ci] apply automated fixes
* Add release notes for PR #7142
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix budget analysis report padding
The padding on the report is too small when the value is large.
* [autofix.ci] apply automated fixes
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* [AI] Enable TypeScript composite project references across monorepo
- Add composite and declaration emit to all package tsconfigs
- Wire root and per-package project references in dependency order
- Replace cross-package include-based typing with referenced outputs
- Fix api TS5055 by emitting declarations to decl-output
- Add desktop-client alias for tests; fix oxlint import order in vite.config
- Add UsersState.data null type and openDatabase return type for strict emit
Co-authored-by: Cursor <cursoragent@cursor.com>
* Remove obsolete TypeScript configuration for API and update build script to emit declarations directly to the output directory. This streamlines the build process and ensures compatibility with the new project structure.
* Refactor TypeScript configuration in API package to remove obsolete decl-output directory and update build scripts. The changes streamline the build process by directing declaration outputs to the @types directory, ensuring better organization and compatibility with the new project structure.
* Add TypeScript declaration emission for loot-core in desktop-electron build process
* Refactor TypeScript configuration in API package to utilize composite references and streamline build scripts. Update include and exclude patterns for improved file management, ensuring better organization of declaration outputs and migration SQL files.
* Refactor TypeScript configuration in loot-core and desktop-client packages to streamline path management and remove obsolete dependencies. Update paths in tsconfig.json files for better organization and compatibility, and adjust yarn.lock to reflect changes in workspace dependencies.
* Update desktop-electron package to utilize loot-core as a workspace dependency. Adjust TypeScript import paths and tsconfig references for improved organization and compatibility across packages.
* Enhance Vite configuration for desktop-client to support Electron-specific conditions and update loot-core package.json to include Electron as a platform for client connection. This improves compatibility for Electron builds.
* Refactor TypeScript configuration across multiple packages to streamline path management. Update tsconfig.json files in root, api, and loot-core packages to improve import paths and maintain compatibility with internal typings.
* Update package dependencies and Vite configuration across component-library and desktop-client. Add vite-tsconfig-paths to component-library and remove it from desktop-client. Refactor Storybook preview file to include a TODO for future refactoring.
* Remove Node-specific path from loot-core package.json for client connection, streamlining platform configuration for Electron.
* Remove loot-core as a workspace dependency from desktop-electron package.json
* Update tsconfig.json to remove reference to desktop-client
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* Add New Taiwan Dollar to currency list
* Add New Taiwan Dollar to currency list
* Fix decimalPlaces for New Taiwan Dollar
Updated decimalPlaces for New Taiwan Dollar from 0 to 2, as suggested by coderabbitai, "Line 62 introduces TWD as zero-decimal, but this codebase currently has an unresolved zero-decimal conversion/storage issue. This risks incorrect persisted amounts for TWD transactions."
* Add upcoming-releass-notes
* Add New Taiwan Dollar (NT$) to available currency
* Add New Taiwan Dollar (NT$) to available currency
* [AI] Refactor YNAB importers to use server-side send() and handler API
Co-authored-by: Cursor <cursoragent@cursor.com>
* Rename 7049.md to 7050.md
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* [AI] Use loot-core workspace in desktop-electron and fix related types
- Add loot-core as workspace dependency in desktop-electron
- Import GlobalPrefsJson from loot-core package in desktop-electron
- Allow null in usersSlice data type (UsersState)
- Add explicit SQL.Database return type to openDatabase in sqlite electron
Made-with: Cursor
* Re-add loot-core as a workspace dependency in desktop-electron
* e:electron: electron backups converted to zip for easy importing
* release notes
* fix lint
* suggestion from rabbit
* Change category from Maintenance to Enhancements
* Pushing before weekend to Monday
* release notes
* lint
* Guard against null
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* fixing AI commit and addressing second comment
* addressing nitpicks
* first attempt at a test
* [autofix.ci] apply automated fixes
* refactor to use condition and fix tests
---------
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* 🔖 (26.3.0)
* Remove used release notes
* Add release notes for PR #7097
* Remove used release notes
* Remove used release notes
* Add release notes for version 26.3.0
* Add new terms to spelling expectation list
* Fix spelling and capitalization in release notes
Corrected spelling of 'reorganisation' to 'reorganization' and updated 'coderabbit' to 'CodeRabbit' for consistency.
* Update patterns.txt to allowlist 'CodeRabbit'
Add 'CodeRabbit' to allowlist of proper nouns.
* Clarify chart theming support in release notes
Updated the release notes to specify bar/pie chart theming support and added details about theme variables for customization.
* Remove 'CodeRabbit' from spelling expectations
* Refactor release notes and improve formatting
Reorganize release notes for clarity and update content.
* Create 2026-03-02-release-26-3-0.md
* Change release date to 2026-03-02
Updated the release date for version 26.3.0.
* Update release notes for version 26.3.0
---------
Co-authored-by: jfdoming <9922514+jfdoming@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com>
* [AI] Make merge-freeze-unfreeze workflow work on fork PRs via pull_request_target
Made-with: Cursor
* Add release notes for the "unfreeze" workflow functionality in fork PRs
* Add empty permissions block to unfreeze job in merge-freeze-unfreeze workflow
* [AI] Add GitHub Action to add PR to Merge Freeze unblocked list when unfreeze label is added
Made-with: Cursor
* Rename 7093.md to 7094.md
* Add concurrency control to unfreeze job in merge-freeze-unfreeze workflow
- Introduced concurrency settings to prevent overlapping executions of the unfreeze job based on labels.
- Updated error handling to abort the process if fetching the current merge freeze status fails, ensuring unblocked PRs are not overwritten.
* Refactor Merge Freeze workflow to simplify PR unblocking process
- Updated the workflow to directly post the PR to the unblocked list without fetching the current freeze status.
- Improved error handling by ensuring the access token is set before proceeding with the API call.
* [AI] Fix mobile rules list items to be full width and left-aligned
- Override Button's default justifyContent/alignItems centering in
ActionableGridListItem to use flex-start alignment
- Add width: 100% to RulesListItem's SpaceBetween to fill the item width
Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com>
* Add release notes for PR #7081
* Change category from Enhancements to Bugfix
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
