[PR #13] [MERGED] remove base_url from config #779

Closed
opened 2025-11-13 12:10:42 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/13
Author: @miloschwartz
Created: 1/8/2025
Status: Merged
Merged: 1/8/2025
Merged by: @miloschwartz

Base: mainHead: dev


📝 Commits (9)

  • 7ab89b1 add example config dir, logos, and update CONTRIBUTING.md
  • 26a165a update dockerignore
  • e1f0834 split base_url into dashboard_url and base_domain
  • b4dd827 Remove unessicary ports
  • ab69ded Allow anything for the ip
  • fb754bc Update docker tags
  • dc7bd41 Complex regex for domains/ips
  • b598fc3 update gitignore
  • 184a22c Merge branch 'main' into dev

📊 Changes

23 files changed (+193 additions, -51 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 Makefile (+8 -6)
📝 README.md (+4 -1)
📝 config/config.example.yml (+2 -1)
📝 docker-compose.example.yml (+2 -5)
📝 install/fs/config.yml (+2 -1)
📝 install/fs/docker-compose.yml (+2 -5)
📝 package.json (+1 -1)
📝 server/apiServer.ts (+1 -1)
📝 server/auth/sendEmailVerificationCode.ts (+1 -1)
📝 server/lib/config.ts (+11 -15)
📝 server/lib/consts.ts (+3 -0)
📝 server/routers/auth/requestPasswordReset.ts (+1 -1)
📝 server/routers/badger/verifySession.ts (+1 -1)
📝 server/routers/org/createOrg.ts (+0 -1)
📝 server/routers/target/createTarget.ts (+29 -1)
📝 server/routers/target/updateTarget.ts (+29 -1)
📝 server/routers/user/inviteUser.ts (+1 -1)
📝 server/setup/copyInConfig.ts (+0 -1)
📝 server/setup/migrations.ts (+3 -1)

...and 3 more files

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Change base_url in config to dashboard_url, and add base_domain. This is to support domains with two-part TLD.
Accept more strings for targets to allow things like container names for compose.

How to test?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/13 **Author:** [@miloschwartz](https://github.com/miloschwartz) **Created:** 1/8/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (9) - [`7ab89b1`](https://github.com/fosrl/pangolin/commit/7ab89b1adb01006b0d303682a5419facae030490) add example config dir, logos, and update CONTRIBUTING.md - [`26a165a`](https://github.com/fosrl/pangolin/commit/26a165ab7175bbc0fe9163fa9844a81bc07d9868) update dockerignore - [`e1f0834`](https://github.com/fosrl/pangolin/commit/e1f0834af4b483639100449c0dbe94738090a3b4) split base_url into dashboard_url and base_domain - [`b4dd827`](https://github.com/fosrl/pangolin/commit/b4dd827ce160e8ac5cc3daedaea8dd012256dffd) Remove unessicary ports - [`ab69ded`](https://github.com/fosrl/pangolin/commit/ab69ded3967f2c5008d8fc123c82e18ee251b1f7) Allow anything for the ip - [`fb754bc`](https://github.com/fosrl/pangolin/commit/fb754bc4e0d5ada7c28784dc8516e43f19177dfd) Update docker tags - [`dc7bd41`](https://github.com/fosrl/pangolin/commit/dc7bd41eb90aefc7512dda48a81a5c71f98e5690) Complex regex for domains/ips - [`b598fc3`](https://github.com/fosrl/pangolin/commit/b598fc3fbaecbe3f034aab40db23127e5a5ef26d) update gitignore - [`184a22c`](https://github.com/fosrl/pangolin/commit/184a22c2382930aa9d672d5799d3248ba5f6c9ee) Merge branch 'main' into dev ### 📊 Changes **23 files changed** (+193 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `Makefile` (+8 -6) 📝 `README.md` (+4 -1) 📝 `config/config.example.yml` (+2 -1) 📝 `docker-compose.example.yml` (+2 -5) 📝 `install/fs/config.yml` (+2 -1) 📝 `install/fs/docker-compose.yml` (+2 -5) 📝 `package.json` (+1 -1) 📝 `server/apiServer.ts` (+1 -1) 📝 `server/auth/sendEmailVerificationCode.ts` (+1 -1) 📝 `server/lib/config.ts` (+11 -15) 📝 `server/lib/consts.ts` (+3 -0) 📝 `server/routers/auth/requestPasswordReset.ts` (+1 -1) 📝 `server/routers/badger/verifySession.ts` (+1 -1) 📝 `server/routers/org/createOrg.ts` (+0 -1) 📝 `server/routers/target/createTarget.ts` (+29 -1) 📝 `server/routers/target/updateTarget.ts` (+29 -1) 📝 `server/routers/user/inviteUser.ts` (+1 -1) 📝 `server/setup/copyInConfig.ts` (+0 -1) 📝 `server/setup/migrations.ts` (+3 -1) _...and 3 more files_ </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Change `base_url` in config to `dashboard_url`, and add `base_domain`. This is to support domains with two-part TLD. Accept more strings for targets to allow things like container names for compose. ## How to test? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:10:42 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#779