github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-03-09 23:35:17 -05:00
Code Issues 94 Packages Projects Releases 48 Wiki Activity

[PR #796] [MERGED] Allow installer to run without requires sudo #844

New Issue
Closed
opened 2025-11-13 12:12:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:12:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/796
Author: @socheatsok78
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/31/2025
Merged by: @oschwartz10612

Base: dev ← Head: non-root-installer

📝 Commits (6)

  • 373441b Fix geolock url in README.md
  • b467d6a Merge pull request #779 from jpgnz/main
  • 56fd366 Allow installer to run without sudo & only need it when need to install Docker
  • 6f35141 Revert "Allow installer to run without sudo & only need it when need to install Docker"
  • c997b86 Re: "Allow installer to run without sudo & only need it when need to install Docker"
  • 9ea7275 Ensure installer check if current user is in docker group

📊 Changes

2 files changed (+43 additions, -5 deletions)

View changed files

📝 README.md (+1 -1)
📝 install/main.go (+42 -4)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Since we only need sudo to install Docker on system that doesn't have Docker installed. it doesn't make any sense to always required running the installer with sudo.

This PR changes that if you need the installer to only generate docker-compose.yml and configs, you don't need sudo. Unless Docker is no installed and you are running on linux based on the check in main.go:

image

How to test?

N/A

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/796 **Author:** [@socheatsok78](https://github.com/socheatsok78) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/31/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `non-root-installer` --- ### 📝 Commits (6) - [`373441b`](https://github.com/fosrl/pangolin/commit/373441b7ab3abfb9145eb5f7dfbbf85c106a3d79) Fix geolock url in README.md - [`b467d6a`](https://github.com/fosrl/pangolin/commit/b467d6afa198a4d77d6399d3418382b5081d7eae) Merge pull request #779 from jpgnz/main - [`56fd366`](https://github.com/fosrl/pangolin/commit/56fd366a7dd29ae33b7c2bf6b13b9a3bb79fc1c8) Allow installer to run without sudo & only need it when need to install Docker - [`6f35141`](https://github.com/fosrl/pangolin/commit/6f3514199ac7588502c3a7a94d4a205f3be79e7d) Revert "Allow installer to run without sudo & only need it when need to install Docker" - [`c997b86`](https://github.com/fosrl/pangolin/commit/c997b8625f7dd5be0b31d7c082d66bb5c14ee6ff) Re: "Allow installer to run without sudo & only need it when need to install Docker" - [`9ea7275`](https://github.com/fosrl/pangolin/commit/9ea7275371bda7a75bd47c2149e7ee2e62d78a44) Ensure `installer` check if current user is in `docker` group ### 📊 Changes **2 files changed** (+43 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `install/main.go` (+42 -4) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Since we only need `sudo` to install Docker on system that doesn't have Docker installed. it doesn't make any sense to always required running the `installer` with `sudo`. This PR changes that if you need the `installer` to only generate `docker-compose.yml` and configs, you don't need `sudo`. Unless Docker is no installed and you are running on `linux` based on the check in `main.go`: <img width="772" alt="image" src="https://github.com/user-attachments/assets/90e4334c-24c8-4e84-b21d-6e347c5ccc26" /> ## How to test? N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:12:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#844
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?