github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-03-09 07:15:04 -05:00
Code Issues 94 Packages Projects Releases 48 Wiki Activity

Subpaths #13

New Issue
Closed
opened 2025-11-13 11:47:29 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-13 11:47:29 -06:00
Owner
Copy Link

Originally created by @Theahlmightyx1 on GitHub (Jan 12, 2025).

I was looking into this for seamless integration with traefik, and have set up traefik as well.
I was informed that Pangolin does not support subpaths and would like to see if I could request as such so that clients experience minimal downtime.

Originally created by @Theahlmightyx1 on GitHub (Jan 12, 2025). I was looking into this for seamless integration with traefik, and have set up traefik as well. I was informed that Pangolin does not support subpaths and would like to see if I could request as such so that clients experience minimal downtime.
GiteaMirror commented 2025-11-13 11:47:30 -06:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jan 12, 2025):

We have heard this request a bunch and I think it could be done. It could have a side effect of making some targets unhappy because I think their cookies and local storage wont be siloed like it is on sub domains so info can leak or it can cause bugs in targets.

That being said I dont see a reason not to implement it and when it works it works!

@oschwartz10612 commented on GitHub (Jan 12, 2025): We have heard this request a bunch and I think it could be done. It could have a side effect of making some targets unhappy because I think their cookies and local storage wont be siloed like it is on sub domains so info can leak or it can cause bugs in targets. That being said I dont see a reason not to implement it and when it works it works!
GiteaMirror commented 2025-11-13 11:47:30 -06:00
Author
Owner
Copy Link

@Theahlmightyx1 commented on GitHub (Jan 12, 2025):

For my setup, subpath support would be really helpful for simplifying configurations where some services need to be hosted on subdomains (e.g., https://service.duckdns.org) while others, like Jellyfin, are better suited for subpaths (e.g., https://example.com/jellyfin). This would make Pangolin much more versatile for self-hosted environments like mine.

I was however unaware of potential data leaks/cookie sharing between services with subpaths. So makes sense if it would not sit well with other users.

Anyway, I will be following this project! Thank you for getting back!

@Theahlmightyx1 commented on GitHub (Jan 12, 2025): For my setup, subpath support would be really helpful for simplifying configurations where some services need to be hosted on subdomains (e.g., https://service.duckdns.org) while others, like Jellyfin, are better suited for subpaths (e.g., https://example.com/jellyfin). This would make Pangolin much more versatile for self-hosted environments like mine. I was however unaware of potential data leaks/cookie sharing between services with subpaths. So makes sense if it would not sit well with other users. Anyway, I will be following this project! Thank you for getting back!
GiteaMirror commented 2025-11-13 11:47:30 -06:00
Author
Owner
Copy Link

@routerino commented on GitHub (Jan 14, 2025):

I would suggest it's better to keep the concerns separate. Domains/Subdomains are a security boundary for many things, like TLS and CORS. When you're mixing and matching services on the same subdomain, you're saying to the browser that they are the same service and can share things like secrets/cookies/whathaveyou. There are many reasons why treating subpaths as subdomains is a bad idea.

Not to mention the fact that most apps do not like being served on subpaths they aren't prepared for and will straight up fail if you try.

For something like pangolin, better to let it not worry about that. If you want to combine services under a single subdomain, have a downstream proxy (like caddy) do that.

@routerino commented on GitHub (Jan 14, 2025): I would suggest it's better to keep the concerns separate. Domains/Subdomains are a security boundary for many things, like TLS and CORS. When you're mixing and matching services on the same subdomain, you're saying to the browser that they are the same service and can share things like secrets/cookies/whathaveyou. There are many reasons why treating subpaths as subdomains is a bad idea. Not to mention the fact that most apps do not like being served on subpaths they aren't prepared for and will straight up fail if you try. For something like pangolin, better to let it not worry about that. If you want to combine services under a single subdomain, have a downstream proxy (like caddy) do that.
GiteaMirror commented 2025-11-13 11:47:31 -06:00
Author
Owner
Copy Link

@miloschwartz commented on GitHub (Jan 16, 2025):

Closing this issue because it's a duplicate feature request in discussion #24 .

@miloschwartz commented on GitHub (Jan 16, 2025): Closing this issue because it's a duplicate feature request in discussion #24 .
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#13
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?