[PR #1993] [MERGED] Make no-reply email address required in install script #2806

New Issue

GiteaMirror · 2026-04-16T09:37:10-05:00

GiteaMirror commented

2026-04-16 09:37:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1993
Author: @Copilot
Created: 12/6/2025
Status: ✅ Merged
Merged: 12/6/2025
Merged by: @oschwartz10612

Base: main ← Head: copilot/fix-install-script-no-reply-email

📝 Commits (2)

60380b7 Initial plan
394d150 Make no-reply email address required when email is enabled

📊 Changes

1 file changed (+16 additions, -12 deletions)

View changed files

📝 install/main.go (+16 -12)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

The install script allowed empty no-reply email during SMTP configuration, causing silent Pangolin service failures at startup.

Changes:

Added validation to require no-reply email when SMTP is enabled
Enhanced prompt with hint: (often the same as SMTP username)
Applied gofmt formatting

// install/main.go
if config.EnableEmail && config.EmailNoReply == "" {
    fmt.Println("Error: No-reply email address is required when email is enabled")
    os.Exit(1)
}

How to test?

Run the installer and enable email configuration. Leave the no-reply email empty - installer will now reject with clear error message instead of creating broken config.

cd install && go build -o installer .
./installer
# When prompted, enable email and leave no-reply empty
# Expected: "Error: No-reply email address is required when email is enabled"

Original prompt

This section details on the original issue you should resolve

<issue_title>Feedback: Install script silently fails on missing no-reply email address</issue_title>
<issue_description>Installing via install script and configuring SMTP, the "no-reply email address" can be left empty. Leaving it empty does however make the pangolin service unhealthy and stops activation of gerbil and traefik services.

The error is displayed in docker compose logs and can be fixed by manually editing the config file. However, as these installation scripts usually are meant to have an easier way than manually doing everything, I would suggest one of the following options:

Add hint from install docs to the install script as well: "This is the sender email address that Pangolin will email from. Many times this should be the same as the username."

Set default of no-reply email address to be the username</issue_description>

<agent_instructions>edit the go script inside install/main.go to make the no-reply email NOT optional</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@oschwartz10612 Yep this sounds like a simple fix. Will take a look!

Fixes fosrl/pangolin#1012

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1993 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/6/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `copilot/fix-install-script-no-reply-email` --- ### 📝 Commits (2) - [`60380b7`](https://github.com/fosrl/pangolin/commit/60380b70edbf6e171ff9aab7dceb746cd42de26c) Initial plan - [`394d150`](https://github.com/fosrl/pangolin/commit/394d1503dda8025d748ddf439db2a5122bcdb4b9) Make no-reply email address required when email is enabled ### 📊 Changes **1 file changed** (+16 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `install/main.go` (+16 -12) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description The install script allowed empty no-reply email during SMTP configuration, causing silent Pangolin service failures at startup. **Changes:** - Added validation to require no-reply email when SMTP is enabled - Enhanced prompt with hint: `(often the same as SMTP username)` - Applied gofmt formatting ```go // install/main.go if config.EnableEmail && config.EmailNoReply == "" { fmt.Println("Error: No-reply email address is required when email is enabled") os.Exit(1) } ``` ## How to test? Run the installer and enable email configuration. Leave the no-reply email empty - installer will now reject with clear error message instead of creating broken config. ```bash cd install && go build -o installer . ./installer # When prompted, enable email and leave no-reply empty # Expected: "Error: No-reply email address is required when email is enabled" ```  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Feedback: Install script silently fails on missing no-reply email address</issue_title> > <issue_description>Installing via install script and configuring SMTP, the "no-reply email address" can be left empty. Leaving it empty does however make the pangolin service unhealthy and stops activation of gerbil and traefik services. > > The error is displayed in docker compose logs and can be fixed by manually editing the config file. However, as these installation scripts usually are meant to have an easier way than manually doing everything, I would suggest one of the following options: > > - Add hint from [install docs](https://docs.fossorial.io/Getting%20Started/quick-install#4-email-configuration) to the install script as well: "This is the sender email address that Pangolin will email from. Many times this should be the same as the username." > - Set default of no-reply email address to be the username</issue_description> > > <agent_instructions>edit the go script inside install/main.go to make the no-reply email NOT optional</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@oschwartz10612</author><body> > Yep this sounds like a simple fix. Will take a look!</body></comment_new> > </comments> > </details>  - Fixes fosrl/pangolin#1012  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-16 09:37:10 -05:00

GiteaMirror closed this issue

2026-04-16 09:37:11 -05:00

GiteaMirror referenced this issue

2026-04-16 09:50:50 -05:00

[PR #2806] [MERGED] Fix invite email encoding #3166

GiteaMirror referenced this issue

2026-04-16 09:51:02 -05:00

[PR #2819] test: add unit and e2e tests for invite link encoding fix #3174

GiteaMirror referenced this issue

2026-04-20 09:16:10 -05:00

[PR #2806] [MERGED] Fix invite email encoding #5109