github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-14 09:31:02 -05:00
Code Issues 660 Packages Projects Releases 74 Wiki Activity

[PR #2819] test: add unit and e2e tests for invite link encoding fix #9955

New Issue
Open
opened 2026-04-30 06:04:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 06:04:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2819
Author: @jbelke
Created: 4/10/2026
Status: 🔄 Open

Base: dev ← Head: test-invite-email-encoding

📝 Commits (1)

  • 4b37d41 test: add unit and e2e tests for invite link encoding fix

📊 Changes

11 files changed (+1544 additions, -19 deletions)

View changed files

➕ cypress.config.ts (+15 -0)
➕ cypress/e2e/invite-link-encoding.cy.ts (+121 -0)
➕ cypress/support/e2e.ts (+19 -0)
📝 package-lock.json (+761 -14)
📝 package.json (+8 -2)
➕ test/invite-link-encoding.test.ts (+429 -0)
➕ test/invite-link-integration.test.ts (+164 -0)
📝 tsconfig.enterprise.json (+1 -1)
📝 tsconfig.oss.json (+1 -1)
📝 tsconfig.saas.json (+1 -1)
➕ vitest.config.ts (+24 -0)

📄 Description

Summary

Adds unit and e2e test coverage for the invite link email encoding fix in #2806. Split out from that PR per review request so the fix can be merged independently while these tests are evaluated.

  • Unit tests (vitest): invite link URL construction preserves @ in email; token parsing; redirect URL construction for login/signup; source-code guards against reintroducing encodeURIComponent in inviteUser.ts / InviteStatusCard.tsx; RFC 3986 reference tests
  • E2E tests (cypress): invite page handling with raw @ and backward-compat with %40; signup/login redirect flows; email pre-fill from invite redirect
  • Build config: vitest devDependency + scripts; cypress config and support files; cypress excluded from tsconfig to avoid build failures

Test plan

  • npm run test (vitest) passes
  • Cypress e2e suite runs against a local instance
  • CI build is unaffected by tsconfig exclusion

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2819 **Author:** [@jbelke](https://github.com/jbelke) **Created:** 4/10/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `test-invite-email-encoding` --- ### 📝 Commits (1) - [`4b37d41`](https://github.com/fosrl/pangolin/commit/4b37d4116594d3ca2b3ffbc90e734c66921a8401) test: add unit and e2e tests for invite link encoding fix ### 📊 Changes **11 files changed** (+1544 additions, -19 deletions) <details> <summary>View changed files</summary> ➕ `cypress.config.ts` (+15 -0) ➕ `cypress/e2e/invite-link-encoding.cy.ts` (+121 -0) ➕ `cypress/support/e2e.ts` (+19 -0) 📝 `package-lock.json` (+761 -14) 📝 `package.json` (+8 -2) ➕ `test/invite-link-encoding.test.ts` (+429 -0) ➕ `test/invite-link-integration.test.ts` (+164 -0) 📝 `tsconfig.enterprise.json` (+1 -1) 📝 `tsconfig.oss.json` (+1 -1) 📝 `tsconfig.saas.json` (+1 -1) ➕ `vitest.config.ts` (+24 -0) </details> ### 📄 Description ## Summary Adds unit and e2e test coverage for the invite link email encoding fix in #2806. Split out from that PR per review request so the fix can be merged independently while these tests are evaluated. - Unit tests (vitest): invite link URL construction preserves `@` in email; token parsing; redirect URL construction for login/signup; source-code guards against reintroducing `encodeURIComponent` in `inviteUser.ts` / `InviteStatusCard.tsx`; RFC 3986 reference tests - E2E tests (cypress): invite page handling with raw `@` and backward-compat with `%40`; signup/login redirect flows; email pre-fill from invite redirect - Build config: vitest devDependency + scripts; cypress config and support files; cypress excluded from tsconfig to avoid build failures ## Test plan - [ ] `npm run test` (vitest) passes - [ ] Cypress e2e suite runs against a local instance - [ ] CI build is unaffected by tsconfig exclusion --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 06:04:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#9955
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?