github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 01:11:38 -05:00
Code Issues 856 Packages Projects Releases 74 Wiki Activity

[PR #2806] [MERGED] Fix invite email encoding #11966

New Issue
Closed
opened 2026-05-06 16:33:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 16:33:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2806
Author: @jbelke
Created: 4/7/2026
Status: ✅ Merged
Merged: 4/11/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix-invite-email-encoding

📝 Commits (1)

  • 028df8b fix: remove encodeURIComponent from invite link email parameter

📊 Changes

2 files changed (+26 additions, -14 deletions)

View changed files

📝 server/routers/user/inviteUser.ts (+14 -8)
📝 src/components/InviteStatusCard.tsx (+12 -6)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Invite links fail email validation due to encoding error.

How to test?

When sending an invite link to john.doe@domain.com the URI encoding converts the @ symbol to %40 resulting in the sign-up form failing validation on an active email address.

Cypress E2E testing added for validation/verification.

sign-in-bug

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2806 **Author:** [@jbelke](https://github.com/jbelke) **Created:** 4/7/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix-invite-email-encoding` --- ### 📝 Commits (1) - [`028df8b`](https://github.com/fosrl/pangolin/commit/028df8bf27a8c5d8879ce931974f7787acb3083e) fix: remove encodeURIComponent from invite link email parameter ### 📊 Changes **2 files changed** (+26 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/user/inviteUser.ts` (+14 -8) 📝 `src/components/InviteStatusCard.tsx` (+12 -6) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Invite links fail email validation due to encoding error. ## How to test? When sending an invite link to john.doe@domain.com the URI encoding converts the @ symbol to %40 resulting in the sign-up form failing validation on an active email address. Cypress E2E testing added for validation/verification. <img width="640" height="791" alt="sign-in-bug" src="https://github.com/user-attachments/assets/79ca7872-08f4-4186-87a3-0b74fd6d6f14" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 16:33:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#11966
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?