fix(a11y): the model picker's active option stays rendered and announced after scrolling the list (#33414)

This commit is contained in:
G30
2026-10-31 05:05:01 +09:00
committed by GitHub
parent be1a36376a
commit 5acb235c82
@@ -966,7 +966,9 @@
aria-autocomplete="list"
aria-expanded={filteredItems.length + downloadTargets.length > 0}
aria-controls="model-selector-list"
aria-activedescendant={filteredItems.length + downloadTargets.length > 0
aria-activedescendant={filteredItems.length + downloadTargets.length > 0 &&
(selectedModelIdx >= filteredItems.length ||
(selectedModelIdx >= visibleStart && selectedModelIdx < visibleEnd))
? `model-option-${selectedModelIdx}`
: undefined}
on:keydown={(e) => {
@@ -994,6 +996,18 @@
selectedModelIdx = 0;
}
if (
listContainer &&
selectedModelIdx < filteredItems.length &&
(selectedModelIdx < visibleStart || selectedModelIdx >= visibleEnd)
) {
listScrollTop = Math.max(
0,
selectedModelIdx * ITEM_HEIGHT - 128 + ITEM_HEIGHT / 2
);
listContainer.scrollTop = listScrollTop;
}
const item = document.querySelector(`[data-arrow-selected="true"]`);
item?.scrollIntoView({
block: 'center',