From 5acb235c82dfde507208cbfd2fcb58907f5990d3 Mon Sep 17 00:00:00 2001 From: G30 <50341825+silentoplayz@users.noreply.github.com> Date: Fri, 30 Oct 2026 16:05:01 -0400 Subject: [PATCH] fix(a11y): the model picker's active option stays rendered and announced after scrolling the list (#33414) --- .../chat/ModelSelector/Selector.svelte | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/lib/components/chat/ModelSelector/Selector.svelte b/src/lib/components/chat/ModelSelector/Selector.svelte index 8d7e54ae73..428d128ba8 100644 --- a/src/lib/components/chat/ModelSelector/Selector.svelte +++ b/src/lib/components/chat/ModelSelector/Selector.svelte @@ -966,7 +966,9 @@ aria-autocomplete="list" aria-expanded={filteredItems.length + downloadTargets.length > 0} aria-controls="model-selector-list" - aria-activedescendant={filteredItems.length + downloadTargets.length > 0 + aria-activedescendant={filteredItems.length + downloadTargets.length > 0 && + (selectedModelIdx >= filteredItems.length || + (selectedModelIdx >= visibleStart && selectedModelIdx < visibleEnd)) ? `model-option-${selectedModelIdx}` : undefined} on:keydown={(e) => { @@ -994,6 +996,18 @@ selectedModelIdx = 0; } + if ( + listContainer && + selectedModelIdx < filteredItems.length && + (selectedModelIdx < visibleStart || selectedModelIdx >= visibleEnd) + ) { + listScrollTop = Math.max( + 0, + selectedModelIdx * ITEM_HEIGHT - 128 + ITEM_HEIGHT / 2 + ); + listContainer.scrollTop = listScrollTop; + } + const item = document.querySelector(`[data-arrow-selected="true"]`); item?.scrollIntoView({ block: 'center',