Plan of Gitea v1.17 #8384

Author

Owner

Copy Link

@zeripath commented on GitHub (Jan 20, 2022):

Previous planning threads:

[PR #2493] [MERGED] add codecov.io service. (#16429)
Incorrect navigation to Releases page (#14477)

@zeripath commented on GitHub (Jan 20, 2022): Previous planning threads: * #16429 * #14477

GiteaMirror commented

Author

Owner

Copy Link

@zeripath commented on GitHub (Jan 20, 2022):

I guess I'll start with some of things I'd like to do:

Context Propagation + "Process" management

This is a series of refactors that will cause the request context to be passed down in called functions. Doing this allows newly created child contexts to be scoped to the request context - enabling process hierarchies to work, better logging, easier db functions, easier permissions checking and scoping. The first steps of this process was in #17125 and the DBContext work.

#17868 - means that all git contexts will now be scoped to the request context.
- Do the same for the DB functions
- #19163 by @wxiaoguang is a good initial start on this.
- pass context into log calls to allow these to print the process ID (or even get the logger from the ctx...)
- add gitea manager process or create admin API for process management
- Once we have context propagation complete we can actually consider dropping the global dependence on setting.AppURL and setting.AppSubURL and make Gitea be possible to be hydra-headed.

Authentication/Authorization

We still need to continue work on the DB password authentication.

- The DB password authentication things really need to be moved out user
- I'd like to make it possible to enforce 2fa
- I want to consider if users want to use their sec key as their method of login without a password

Then there are OAuth scoping and tokens:

- OAuth Tokens scopable to github like permissions
- With the context propagation above permissions checks could actually be performed a bit more clearly.
- Deprecate the old Token scheme

We also need to make it possible to force logout of sessions for the current user - useful additionally for admin.

- Refactor sessions infrastructure to account for this.

Dump/Restore

I think we should stop dumping to "SQL" - and instead dump to a SQLite db file. We should then be able to restore from this a lot easier!

Internal SSH Server

This is currently broken for modern ssh versions. See #17798 - we've gotta sort this out...

If the underlying library is not fixed by February I think I'm gonna have to consider forking this and fixing this 😢 (Unless someone else wants to do this?!)

Federation

This work stream will be discussed elsewhere

Misc

#18064 - this allows admins to purge a user and all of their repositories
#17902
- I think this work also shows the basics of how to approach resolve conflicts - but I'm not sure if I will get to this.
#18335
#15928 - This also contains some protection against 0 worker/0 boost worker configurations.
- I think the notifications UI could do with some work. It currently just shows all of the notifications but I think we should really be able to make it searchable etc. The problem is when I will be able to get to this.

Work with others

#18341 - Adds more deprecation notices to the settings
#17308 - Contains a significant refactor for Wrap that means instead of performing reflection at routing time these are precalculated

That's probably enough to be getting on with however, I'd like to list some potential refactors that I'd like to consider:

Potential Refactors

As mentioned above, context passing means we can consider "hydra" heading dropping the dependence on the global AppURL and instead get this set at the server level.
- This would allow users to more easily mount gitea in two places and also reduce the problems from the ROOT_URL setting.
Once we stop having global dependence on setting.AppURL we'll likely find that a lot of packages really only look at particular settings. If we implement configurable we can actually consider having packages do this themselves.
I think we need to use more generation especially in the routers.
I think we should either consider using the go-sdk in the (especially the API) integration tests or get swagger to generate an API.

@zeripath commented on GitHub (Jan 20, 2022): I guess I'll start with some of things I'd like to do: ## Context Propagation + "Process" management This is a series of refactors that will cause the request context to be passed down in called functions. Doing this allows newly created child contexts to be scoped to the request context - enabling process hierarchies to work, better logging, easier db functions, easier permissions checking and scoping. The first steps of this process was in #17125 and the DBContext work. * #17868 - means that all git contexts will now be scoped to the request context. * [ ] - Do the same for the DB functions * #19163 by @wxiaoguang is a good initial start on this. * [ ] - pass context into log calls to allow these to print the process ID (or even get the logger from the ctx...) * [ ] - add `gitea manager process` or create admin API for process management * [ ] - Once we have context propagation complete we can actually consider dropping the global dependence on setting.AppURL and setting.AppSubURL and make Gitea be possible to be hydra-headed. ## Authentication/Authorization We still need to continue work on the DB password authentication. * [ ] - The DB password authentication things really need to be moved out user * [ ] - I'd like to make it possible to enforce 2fa * [ ] - I want to consider if users want to use their sec key as their method of login without a password Then there are OAuth scoping and tokens: * [ ] - OAuth Tokens scopable to github like permissions * With the context propagation above permissions checks could actually be performed a bit more clearly. * [ ] - Deprecate the old Token scheme We also need to make it possible to force logout of sessions for the current user - useful additionally for admin. * [ ] - Refactor sessions infrastructure to account for this. ## Dump/Restore I think we should stop dumping to "SQL" - and instead dump to a SQLite db file. We should then be able to restore from this a lot easier! ## Internal SSH Server This is currently broken for modern ssh versions. See #17798 - we've gotta sort this out... If the underlying library is not fixed by February I think I'm gonna have to consider forking this and fixing this :cry: (Unless someone else wants to do this?!) ## Federation This work stream will be discussed elsewhere ## Misc * #18064 - this allows admins to purge a user and all of their repositories * #17902 * I think this work also shows the basics of how to approach resolve conflicts - but I'm not sure if I will get to this. * #18335 * #15928 - This also contains some protection against 0 worker/0 boost worker configurations. * [ ] - I think the notifications UI could do with some work. It currently just shows all of the notifications but I think we should really be able to make it searchable etc. The problem is when I will be able to get to this. ## Work with others * #18341 - Adds more deprecation notices to the settings * #17308 - Contains a significant refactor for Wrap that means instead of performing reflection at routing time these are precalculated That's probably enough to be getting on with however, I'd like to list some potential refactors that I'd like to consider: ### Potential Refactors * As mentioned above, context passing means we can consider "hydra" heading dropping the dependence on the global AppURL and instead get this set at the server level. - This would allow users to more easily mount gitea in two places and also reduce the problems from the ROOT_URL setting. * Once we stop having global dependence on setting.AppURL we'll likely find that a lot of packages really only look at particular settings. If we implement configurable we can actually consider having packages do this themselves. * I think we need to use more generation especially in the routers. * I think we should either consider using the go-sdk in the (especially the API) integration tests or get swagger to generate an API.

GiteaMirror commented

Author

Owner

Copy Link

@techknowlogick commented on GitHub (Jan 20, 2022):

Placeholder for my plan, will edit this post as I have things to add.

Currently just maintenance tasks are on top of my head:

Due to crowdin API deprecation, the cron task needs to be updated.
With upcoming release of golang 1.18, we will need to build with that (update drone, docker, & xgo)

refactor:

move some user columns to use user_settings table instead

features:

labels for milestones

As mentioned above, federation tasks will be discussed elsewhere.

Also, general upkeep of our infra & coordination with sponsors

@techknowlogick commented on GitHub (Jan 20, 2022): Placeholder for my plan, will edit this post as I have things to add. Currently just maintenance tasks are on top of my head: * Due to crowdin API deprecation, the cron task needs to be updated. * With upcoming release of golang 1.18, we will need to build with that (update drone, docker, & xgo) refactor: * move some user columns to use user_settings table instead features: * labels for milestones As mentioned above, federation tasks will be discussed elsewhere. Also, general upkeep of our infra & coordination with sponsors

GiteaMirror commented

Author

Owner

Copy Link

@silverwind commented on GitHub (Jan 20, 2022):

Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery
Finish removal of icon fonts
Finish removal of all color values in CSS in favor of variables

@silverwind commented on GitHub (Jan 20, 2022): - [ ] Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery - [ ] Finish removal of icon fonts - [ ] Finish removal of all color values in CSS in favor of variables

GiteaMirror commented

Author

Owner

Copy Link

@lafriks commented on GitHub (Jan 20, 2022):

Finally finish priority labels (#11669)
Secret storage (#14483)

@lafriks commented on GitHub (Jan 20, 2022): * [ ] Finally finish priority labels (#11669) * [ ] Secret storage (#14483)

GiteaMirror commented

Author

Owner

Copy Link

@vwbusguy commented on GitHub (Jan 20, 2022):

I would love to see these make the cut. This is some low hanging fruit that's been around for a while that would be a great quality of life improvement: https://github.com/go-gitea/gitea/issues/16429#issuecomment-919345943

Ref.
WIP: wiki - page toc and directory support #7225
WIP: wiki - add toc to wiki pages and rendered md files #7182
TOC for Wiki Pages #822

@vwbusguy commented on GitHub (Jan 20, 2022): I would love to see these make the cut. This is some low hanging fruit that's been around for a while that would be a great quality of life improvement: https://github.com/go-gitea/gitea/issues/16429#issuecomment-919345943 Ref. WIP: wiki - page toc and directory support #7225 WIP: wiki - add toc to wiki pages and rendered md files #7182 TOC for Wiki Pages #822

GiteaMirror commented

Author

Owner

Copy Link

@techknowlogick commented on GitHub (Jan 20, 2022):

@vwbusguy please see note in original post:

(Reminder, this thread is for things you PLAN TO DO YOURSELF, not things you want other people to do.)

@techknowlogick commented on GitHub (Jan 20, 2022): @vwbusguy please see note in original post: > (Reminder, this thread is for things you PLAN TO DO YOURSELF, not things you want other people to do.)

GiteaMirror commented

Author

Owner

Copy Link

@lunny commented on GitHub (Jan 21, 2022):

Finish #18165 and finally move the Gitea repository itself to https://gitea.com/gitea/gitea.git
More refactors backend code (models, modules, services) #16455 [PR #5218] [MERGED] fix sqlite and mssql lock (#5214) (#17704)
#18147 So that we can move towards distributed git storage.
#18177
#19318 & #19321 Make API & Web routes separately, then API should have a slight better performance and less memory usage.
#18058 Move some configuration from app.ini to admin WebUI. At first those don't need to restart Gitea.
Internal CI/CD which is similar as Github Actions and compatible with Github Actions configuration files.

@lunny commented on GitHub (Jan 21, 2022): - [ ] Finish #18165 and finally move the Gitea repository itself to https://gitea.com/gitea/gitea.git - [ ] More refactors backend code (models, modules, services) #16455 #17704 - [ ] #18147 So that we can move towards distributed git storage. - [ ] #18177 - [ ] #19318 & #19321 Make API & Web routes separately, then API should have a slight better performance and less memory usage. - [ ] #18058 Move some configuration from app.ini to admin WebUI. At first those don't need to restart Gitea. - [ ] Internal CI/CD which is similar as Github Actions and compatible with Github Actions configuration files.

GiteaMirror commented

Author

Owner

Copy Link

@KN4CK3R commented on GitHub (Jan 21, 2022):

Finish [PR #2625] [CLOSED] Move all docker stuff under docker/ directory (#16510)
Once the package registry is ready, finish the docker/container registry
Work towards federation

@KN4CK3R commented on GitHub (Jan 21, 2022): - [x] Finish #16510 - [x] Once the package registry is ready, finish the docker/container registry - Work towards federation

GiteaMirror commented

Author

Owner

Copy Link

@Gusted commented on GitHub (Jan 23, 2022):

Bit late to the party.

Get https://github.com/go-gitea/gitea/pull/17711 merged
Do some more security stuff (unintentionally vague)
Improve QoL of Gitea, with little quirks that other Git services have.

@Gusted commented on GitHub (Jan 23, 2022): Bit late to the party. - [ ] Get https://github.com/go-gitea/gitea/pull/17711 merged - [ ] Do some more security stuff (~~un~~intentionally vague) - [ ] Improve QoL of Gitea, with little quirks that other Git services have.

GiteaMirror commented

Author

Owner

Copy Link

@richmahn commented on GitHub (Feb 22, 2022):

Still in great need of a UI for conflict resolving #9014. I said 1.5 years ago I would work on this...still seeking to find the time, hopefully for 1.17.

@richmahn commented on GitHub (Feb 22, 2022): Still in great need of a UI for conflict resolving #9014. I said 1.5 years ago I would work on this...still seeking to find the time, hopefully for 1.17.

GiteaMirror commented

Author

Owner

Copy Link

@delvh commented on GitHub (Mar 1, 2022):

Getting #19007 merged.

@delvh commented on GitHub (Mar 1, 2022): - [x] Getting #19007 merged.

GiteaMirror commented

Author

Owner

Copy Link

@more-pepsi commented on GitHub (Mar 30, 2022):

Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery

Finish removal of icon fonts

Finish removal of all color values in CSS in favor of variables

I'm looking for some starter tasks if you want to pas some tasks on. I"m a JavaScript expert, but a little rusty with frameworks, its been years. So i'll just follow your lead.

@more-pepsi commented on GitHub (Mar 30, 2022): > * [ ] Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery > * [ ] Finish removal of icon fonts > * [ ] Finish removal of all color values in CSS in favor of variables I'm looking for some starter tasks if you want to pas some tasks on. I"m a JavaScript expert, but a little rusty with frameworks, its been years. So i'll just follow your lead.

GiteaMirror commented

Author

Owner

Copy Link

@silverwind commented on GitHub (Mar 31, 2022):

Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery

Finish removal of icon fonts

Finish removal of all color values in CSS in favor of variables

I'm looking for some starter tasks if you want to pas some tasks on. I"m a JavaScript expert, but a little rusty with frameworks, its been years. So i'll just follow your lead.

Feel free to have a look at integrating https://github.com/dgraham/eslint-plugin-jquery with a few starter rules. I think no-ajax is a prime candidate where we can replace AJAX calls with native fetch. There will be many such AJAX cases in the code, so getting this rule alone to work will already be quite an extensive task.

Other starter candidates might be rules that only trigger a few errors in the code, those should be easy to refactor to native DOM usage.

@silverwind commented on GitHub (Mar 31, 2022): > > * [ ] Start refactoring out jQuery with the help of https://github.com/dgraham/eslint-plugin-jquery > > * [ ] Finish removal of icon fonts > > * [ ] Finish removal of all color values in CSS in favor of variables > > I'm looking for some starter tasks if you want to pas some tasks on. I"m a JavaScript expert, but a little rusty with frameworks, its been years. So i'll just follow your lead. Feel free to have a look at integrating https://github.com/dgraham/eslint-plugin-jquery with a few starter rules. I think `no-ajax` is a prime candidate where we can replace AJAX calls with native `fetch`. There will be many such AJAX cases in the code, so getting this rule alone to work will already be quite an extensive task. Other starter candidates might be rules that only trigger a few errors in the code, those should be easy to refactor to native DOM usage.

GiteaMirror commented