[PR #5445] [MERGED] [backport]word-break the WebHook url to prevent a ui-break #17798

New Issue

GiteaMirror · 2025-11-02T15:52:10-06:00

GiteaMirror commented

2025-11-02 15:52:10 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5445
Author: @r-52
Created: 12/2/2018
Status: ✅ Merged
Merged: 12/2/2018
Merged by: @techknowlogick

Base: release/v1.6 ← Head: r-backport-url-wrap-in-webhooks

📝 Commits (2)

dbc1484 word-break the WebHook url to prevent a ui-break
4a6122a Merge branch 'release/v1.6' into r-backport-url-wrap-in-webhooks

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 templates/repo/settings/webhook/list.tmpl (+1 -1)

📄 Description

the requested backport for https://github.com/go-gitea/gitea/pull/5432

right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class dont-break-out
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
text text-break-word, but that would duplicate the dont-break-out
class just for text elements that use the text class.

fixes: https://github.com/go-gitea/gitea/issues/5416

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5445 **Author:** [@r-52](https://github.com/r-52) **Created:** 12/2/2018 **Status:** ✅ Merged **Merged:** 12/2/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `release/v1.6` ← **Head:** `r-backport-url-wrap-in-webhooks` --- ### 📝 Commits (2) - [`dbc1484`](https://github.com/go-gitea/gitea/commit/dbc14849d0fae5f0c0b26cf473f2c040ef49b08b) word-break the WebHook url to prevent a ui-break - [`4a6122a`](https://github.com/go-gitea/gitea/commit/4a6122a0f87d2ee53b9606cf6294760e6261f759) Merge branch 'release/v1.6' into r-backport-url-wrap-in-webhooks ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `templates/repo/settings/webhook/list.tmpl` (+1 -1) </details> ### 📄 Description the requested backport for https://github.com/go-gitea/gitea/pull/5432 right now, the url is displayed with an anchor tag with no classes. If the url is really really long, the url will break out of the containing div and (depending on the url length) the browser shows the horizontal scrollbar. This pr makes use of the already existing css class `dont-break-out` which gives all the anchor the necessary properties to prevent the break. Another solution could be to introduce some classes like `text text-break-word`, but that would duplicate the `dont-break-out` class just for text elements that use the `text` class. fixes: https://github.com/go-gitea/gitea/issues/5416 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 15:52:10 -06:00

GiteaMirror closed this issue

2025-11-02 15:52:17 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17798