[PR #2545] [MERGED] Use named ActionType constants in template helper #16455

Closed
opened 2025-11-02 12:11:03 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/2545
Author: @ethantkoenig
Created: 9/19/2017
Status: Merged
Merged: 9/20/2017
Merged by: @lunny

Base: masterHead: cleanup/use_named_constants


📝 Commits (2)

  • f34c8bb Use named ActionType constants in template helper
  • 2c705ad Merge branch 'master' into cleanup/use_named_constants

📊 Changes

2 files changed (+13 additions, -15 deletions)

View changed files

📝 models/action.go (+2 -3)
📝 modules/templates/helper.go (+11 -12)

📄 Description

Use constants instead of magic numbers in template helper. Also resolves a related TODO

cc @daviian


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/2545 **Author:** [@ethantkoenig](https://github.com/ethantkoenig) **Created:** 9/19/2017 **Status:** ✅ Merged **Merged:** 9/20/2017 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `cleanup/use_named_constants` --- ### 📝 Commits (2) - [`f34c8bb`](https://github.com/go-gitea/gitea/commit/f34c8bb0ece67570e51078d57806752966d73746) Use named ActionType constants in template helper - [`2c705ad`](https://github.com/go-gitea/gitea/commit/2c705ad5f25bbda7e26bcd21782829eba4cfafb3) Merge branch 'master' into cleanup/use_named_constants ### 📊 Changes **2 files changed** (+13 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `models/action.go` (+2 -3) 📝 `modules/templates/helper.go` (+11 -12) </details> ### 📄 Description Use constants instead of magic numbers in template helper. Also resolves a related `TODO` cc @daviian --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 12:11:04 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#16455