ProtectedBranch missing from models.go init #384

New Issue

GiteaMirror · 2025-11-02T03:21:06-06:00

GiteaMirror commented

2025-11-02 03:21:06 -06:00

Originally created by @morrildl on GitHub (Feb 22, 2017).

With a new installation with clean git repos, a newly created repo cannot be pushed to. update.log says:

2017/02/22 13:24:38 [T] pushing to 1 master
2017/02/22 13:24:38 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed
2017/02/22 13:38:26 [T] pushing to 2 lol
2017/02/22 13:38:26 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed

Adding a bit of code to update:63 to print the err != nil shows:

2017/02/22 13:50:05 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed%!(EXTRA *pq.Error=pq: relation "protected_branch" does not exist)

This seems to be the same root cause as in #1012 -- and adding new(ProtectedBranch), to the init() also fixes this error, and I can push.

diff --git a/models/models.go b/models/models.go
index 33268fa..0840b46 100644
--- a/models/models.go
+++ b/models/models.go
@@ -114,6 +114,8 @@ func init() {
                new(TwoFactor),
                new(RepoUnit),
                new(RepoRedirect),
+               new(ExternalLoginUser),
+               new(ProtectedBranch),
        )
 
        gonicNames := []string{"SSL", "UID"}

Originally created by @morrildl on GitHub (Feb 22, 2017). With a new installation with clean git repos, a newly created repo cannot be pushed to. update.log says: 2017/02/22 13:24:38 [T] pushing to 1 master 2017/02/22 13:24:38 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed 2017/02/22 13:38:26 [T] pushing to 2 lol 2017/02/22 13:38:26 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed Adding a bit of code to update:63 to print the `err != nil` shows: 2017/02/22 13:50:05 [.../gitea/cmd/update.go:63 runUpdate()] [F] retrieve protected branches information failed%!(EXTRA *pq.Error=pq: relation "protected_branch" does not exist) This seems to be the same root cause as in #1012 -- and adding `new(ProtectedBranch),` to the init() also fixes this error, and I can push. diff --git a/models/models.go b/models/models.go index 33268fa..0840b46 100644 --- a/models/models.go +++ b/models/models.go @@ -114,6 +114,8 @@ func init() { new(TwoFactor), new(RepoUnit), new(RepoRedirect), + new(ExternalLoginUser), + new(ProtectedBranch), ) gonicNames := []string{"SSL", "UID"}

GiteaMirror added the type/bug label 2025-11-02 03:21:06 -06:00

GiteaMirror closed this issue

2025-11-02 03:21:07 -06:00

GiteaMirror commented

2025-11-02 03:21:07 -06:00

@strk commented on GitHub (Feb 23, 2017):

Duplicate of #1012

@strk commented on GitHub (Feb 23, 2017): Duplicate of #1012

GiteaMirror commented

2025-11-02 03:21:07 -06:00

@strk commented on GitHub (Feb 23, 2017):

(ok, not a duplicate, now that I see #1021)