github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #384] [MERGED] Fix random string generator #15348

New Issue
Closed
opened 2025-11-02 11:44:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 11:44:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/384
Author: @denji
Created: 12/14/2016
Status: ✅ Merged
Merged: 12/20/2016
Merged by: @tboerger

Base: master ← Head: badrandom

📝 Commits (2)

  • 9a742b5 Remove unused custom-alphabet feature of random string generator
  • 76afd53 Fixes variable (un)initialization mixed assign

📊 Changes

11 files changed (+94 additions, -35 deletions)

View changed files

📝 models/migrations/migrations.go (+6 -2)
📝 models/org.go (+6 -2)
📝 models/user.go (+7 -3)
📝 models/user_mail.go (+3 -1)
📝 modules/base/tool.go (+23 -9)
📝 modules/base/tool_test.go (+3 -1)
📝 routers/admin/users.go (+5 -1)
📝 routers/api/v1/admin/user.go (+5 -1)
📝 routers/install.go (+17 -11)
📝 routers/user/auth.go (+14 -3)
📝 routers/user/setting.go (+5 -1)

📄 Description

This PR fixes the following issues gogits/gogs#3953:

  • The random string generator was modulo-biased.
  • The random string generator silently ignored any errors returned by rand.Read. In the worst case, GetRandomString would simply return an empty string.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/384 **Author:** [@denji](https://github.com/denji) **Created:** 12/14/2016 **Status:** ✅ Merged **Merged:** 12/20/2016 **Merged by:** [@tboerger](https://github.com/tboerger) **Base:** `master` ← **Head:** `badrandom` --- ### 📝 Commits (2) - [`9a742b5`](https://github.com/go-gitea/gitea/commit/9a742b564379acb96091a25ee4a4007158b88277) Remove unused custom-alphabet feature of random string generator - [`76afd53`](https://github.com/go-gitea/gitea/commit/76afd53c06b71478481b8a2f88e17f0ba6cf775c) Fixes variable (un)initialization mixed assign ### 📊 Changes **11 files changed** (+94 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `models/migrations/migrations.go` (+6 -2) 📝 `models/org.go` (+6 -2) 📝 `models/user.go` (+7 -3) 📝 `models/user_mail.go` (+3 -1) 📝 `modules/base/tool.go` (+23 -9) 📝 `modules/base/tool_test.go` (+3 -1) 📝 `routers/admin/users.go` (+5 -1) 📝 `routers/api/v1/admin/user.go` (+5 -1) 📝 `routers/install.go` (+17 -11) 📝 `routers/user/auth.go` (+14 -3) 📝 `routers/user/setting.go` (+5 -1) </details> ### 📄 Description This PR fixes the following issues gogits/gogs#3953: * The random string generator was [modulo-biased](https://stackoverflow.com/a/10984975). * The random string generator silently ignored any errors returned by `rand.Read`. In the worst case, `GetRandomString` would simply return an empty string. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 11:44:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#15348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?