[PR #7584] [MERGED] fix: log error when misconfigured #7420

Closed
opened 2026-03-13 13:35:46 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7584
Author: @himself65
Created: 1/24/2026
Status: Merged
Merged: 1/24/2026
Merged by: @himself65

Base: canaryHead: himself65/2026/01/23/error


📝 Commits (2)

📊 Changes

2 files changed (+17 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/context/create-context.test.ts (+5 -0)
📝 packages/better-auth/src/context/create-context.ts (+12 -0)

📄 Description

Upstream: https://github.com/better-auth/better-auth/issues/6447


Summary by cubic

Log an error when the memory adapter is used with advanced.database.generateId set to false, so misconfigurations don’t fail silently. Added a test to ensure the “Misconfiguration detected” error is emitted.

Written for commit 63d1b9c603. Summary will update on new commits.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7584 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/23/error` --- ### 📝 Commits (2) - [`f728839`](https://github.com/better-auth/better-auth/commit/f7288398a0b20b86f4118311520e7eea8719381c) fix: log error when misconfigured - [`63d1b9c`](https://github.com/better-auth/better-auth/commit/63d1b9c60308414689d15ab364fa9bd03670cede) fix: issue ### 📊 Changes **2 files changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/context/create-context.test.ts` (+5 -0) 📝 `packages/better-auth/src/context/create-context.ts` (+12 -0) </details> ### 📄 Description Upstream: https://github.com/better-auth/better-auth/issues/6447 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Log an error when the memory adapter is used with advanced.database.generateId set to false, so misconfigurations don’t fail silently. Added a test to ensure the “Misconfiguration detected” error is emitted. <sup>Written for commit 63d1b9c60308414689d15ab364fa9bd03670cede. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:35:46 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7420