github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7448] [MERGED] v1.4.15 #24221

New Issue
Closed
opened 2026-04-15 22:14:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:14:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7448
Author: @himself65
Created: 1/18/2026
Status: ✅ Merged
Merged: 1/18/2026
Merged by: @himself65

Base: main ← Head: v1.4.15-staging

📝 Commits (3)

  • 2b75e5f fix: update TanStack imports to use server subpath (#7446)
  • 1f2e83b fix(client): deep merge plugin actions to preserve all methods (#7407)
  • f159949 refactor: simplify options type (#7420)

📊 Changes

22 files changed (+642 additions, -111 deletions)

View changed files

➕ .postmortem/tanstack-start-server-core.md (+104 -0)
📝 knip.jsonc (+2 -2)
📝 packages/better-auth/package.json (+6 -6)
📝 packages/better-auth/src/adapters/create-test-suite.ts (+1 -1)
📝 packages/better-auth/src/adapters/tests/adapter-factory.test.ts (+1 -1)
📝 packages/better-auth/src/auth/base.ts (+1 -3)
📝 packages/better-auth/src/auth/full.test.ts (+1 -1)
📝 packages/better-auth/src/auth/full.ts (+1 -1)
➖ packages/better-auth/src/auth/index.ts (+0 -1)
📝 packages/better-auth/src/auth/minimal.test.ts (+8 -1)
📝 packages/better-auth/src/auth/minimal.ts (+1 -3)
📝 packages/better-auth/src/client/client.test.ts (+54 -1)
📝 packages/better-auth/src/client/config.ts (+4 -3)
📝 packages/better-auth/src/client/test-plugin.ts (+31 -0)
📝 packages/better-auth/src/db/get-migration-schema.test.ts (+1 -1)
📝 packages/better-auth/src/db/internal-adapter.test.ts (+1 -1)
📝 packages/better-auth/src/index.ts (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start-solid.ts (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -1)
📝 packages/better-auth/src/plugins/organization/client.test.ts (+1 -1)

...and 2 more files

📄 Description

Summary by cubic

Fix TanStack Start integration by switching to framework-specific /server imports and updating peer deps to avoid Vite pre-bundling errors. Also deep-merge client plugin actions to preserve methods from multiple plugins and simplify Better Auth options typing.

  • Bug Fixes

    • TanStack Start: use imports from @tanstack/react-start/server and @tanstack/solid-start/server; updated peer deps to @tanstack/react-start and @tanstack/solid-start.
    • Client plugins: deep-merge actions (via defu) so plugins adding the same top-level key (e.g., signIn) don’t overwrite each other.

  • Refactors

    • Simplified BetterAuth options types (removed Record<never, never>) and standardized betterAuth export to auth/full.

Written for commit f159949c03. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7448 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/18/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `main` ← **Head:** `v1.4.15-staging` --- ### 📝 Commits (3) - [`2b75e5f`](https://github.com/better-auth/better-auth/commit/2b75e5f6bde9b4386663cacff2cd6bac6c89da47) fix: update TanStack imports to use server subpath (#7446) - [`1f2e83b`](https://github.com/better-auth/better-auth/commit/1f2e83bad3f3d67daf0946f604182791aac80f2b) fix(client): deep merge plugin actions to preserve all methods (#7407) - [`f159949`](https://github.com/better-auth/better-auth/commit/f159949c03b48495f523e7beae04c1e48a843e87) refactor: simplify options type (#7420) ### 📊 Changes **22 files changed** (+642 additions, -111 deletions) <details> <summary>View changed files</summary> ➕ `.postmortem/tanstack-start-server-core.md` (+104 -0) 📝 `knip.jsonc` (+2 -2) 📝 `packages/better-auth/package.json` (+6 -6) 📝 `packages/better-auth/src/adapters/create-test-suite.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/tests/adapter-factory.test.ts` (+1 -1) 📝 `packages/better-auth/src/auth/base.ts` (+1 -3) 📝 `packages/better-auth/src/auth/full.test.ts` (+1 -1) 📝 `packages/better-auth/src/auth/full.ts` (+1 -1) ➖ `packages/better-auth/src/auth/index.ts` (+0 -1) 📝 `packages/better-auth/src/auth/minimal.test.ts` (+8 -1) 📝 `packages/better-auth/src/auth/minimal.ts` (+1 -3) 📝 `packages/better-auth/src/client/client.test.ts` (+54 -1) 📝 `packages/better-auth/src/client/config.ts` (+4 -3) 📝 `packages/better-auth/src/client/test-plugin.ts` (+31 -0) 📝 `packages/better-auth/src/db/get-migration-schema.test.ts` (+1 -1) 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+1 -1) 📝 `packages/better-auth/src/index.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start-solid.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/organization/client.test.ts` (+1 -1) _...and 2 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fix TanStack Start integration by switching to framework-specific /server imports and updating peer deps to avoid Vite pre-bundling errors. Also deep-merge client plugin actions to preserve methods from multiple plugins and simplify Better Auth options typing. - **Bug Fixes** - TanStack Start: use imports from @tanstack/react-start/server and @tanstack/solid-start/server; updated peer deps to @tanstack/react-start and @tanstack/solid-start. - Client plugins: deep-merge actions (via defu) so plugins adding the same top-level key (e.g., signIn) don’t overwrite each other. - **Refactors** - Simplified BetterAuth options types (removed Record<never, never>) and standardized betterAuth export to auth/full. <sup>Written for commit f159949c03b48495f523e7beae04c1e48a843e87. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:14:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?