github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7420] [MERGED] refactor: simplify options type #32898

New Issue
Closed
opened 2026-04-17 23:36:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:36:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7420
Author: @himself65
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/17/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/fix-type

📝 Commits (6)

  • 8c9cd42 refactor: simplify options type by removing unnecessary Record<never, never>
  • 72aadf7 refactor: simplify options type by removing unnecessary Record<never, never>
  • 069c7e9 refactor: simplify options type by removing unnecessary Record<never, never>
  • 7888482 refactor: simplify options type by removing unnecessary Record<never, never>
  • 3fcf487 refactor: simplify options type by removing unnecessary Record<never, never>
  • db36c26 fix: update import path in organization client test after file rename

📊 Changes

13 files changed (+19 additions, -17 deletions)

View changed files

📝 packages/better-auth/src/adapters/create-test-suite.ts (+1 -1)
📝 packages/better-auth/src/adapters/tests/adapter-factory.test.ts (+1 -1)
📝 packages/better-auth/src/auth/base.ts (+1 -3)
📝 packages/better-auth/src/auth/full.test.ts (+1 -1)
📝 packages/better-auth/src/auth/full.ts (+1 -1)
➖ packages/better-auth/src/auth/index.ts (+0 -1)
📝 packages/better-auth/src/auth/minimal.test.ts (+8 -1)
📝 packages/better-auth/src/auth/minimal.ts (+1 -3)
📝 packages/better-auth/src/db/get-migration-schema.test.ts (+1 -1)
📝 packages/better-auth/src/db/internal-adapter.test.ts (+1 -1)
📝 packages/better-auth/src/index.ts (+1 -1)
📝 packages/better-auth/src/plugins/organization/client.test.ts (+1 -1)
📝 packages/better-auth/src/test-utils/test-instance.ts (+1 -1)

📄 Description

Summary by cubic

Simplified the options type by removing the unnecessary Record<never, never> from betterAuth and createBetterAuth. This makes the API easier to use and improves type inference with no runtime changes.

  • Refactors
    • Removed Record<never, never> from Options in base.ts, full.ts, and minimal.ts; updated exports/imports to use auth/full.
    • No behavior changes; type signatures are cleaner and more readable.

Written for commit db36c26df4. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7420 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/17/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/fix-type` --- ### 📝 Commits (6) - [`8c9cd42`](https://github.com/better-auth/better-auth/commit/8c9cd42c40f7646a771ac9fd36f69ad975416aa3) refactor: simplify options type by removing unnecessary `Record<never, never>` - [`72aadf7`](https://github.com/better-auth/better-auth/commit/72aadf7eceb765da436e814175e343fe042f1155) refactor: simplify options type by removing unnecessary `Record<never, never>` - [`069c7e9`](https://github.com/better-auth/better-auth/commit/069c7e94d8af9a46675f650fea081a7f554fe9ee) refactor: simplify options type by removing unnecessary `Record<never, never>` - [`7888482`](https://github.com/better-auth/better-auth/commit/7888482ed790e28fa360264f1427d801ca99031e) refactor: simplify options type by removing unnecessary `Record<never, never>` - [`3fcf487`](https://github.com/better-auth/better-auth/commit/3fcf48717e30814fa31fe1f72bf54ce9b1b4237b) refactor: simplify options type by removing unnecessary `Record<never, never>` - [`db36c26`](https://github.com/better-auth/better-auth/commit/db36c26df47f14c7a18be6640de012367cf9ba8d) fix: update import path in organization client test after file rename ### 📊 Changes **13 files changed** (+19 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/create-test-suite.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/tests/adapter-factory.test.ts` (+1 -1) 📝 `packages/better-auth/src/auth/base.ts` (+1 -3) 📝 `packages/better-auth/src/auth/full.test.ts` (+1 -1) 📝 `packages/better-auth/src/auth/full.ts` (+1 -1) ➖ `packages/better-auth/src/auth/index.ts` (+0 -1) 📝 `packages/better-auth/src/auth/minimal.test.ts` (+8 -1) 📝 `packages/better-auth/src/auth/minimal.ts` (+1 -3) 📝 `packages/better-auth/src/db/get-migration-schema.test.ts` (+1 -1) 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+1 -1) 📝 `packages/better-auth/src/index.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/organization/client.test.ts` (+1 -1) 📝 `packages/better-auth/src/test-utils/test-instance.ts` (+1 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Simplified the options type by removing the unnecessary Record<never, never> from betterAuth and createBetterAuth. This makes the API easier to use and improves type inference with no runtime changes. - **Refactors** - Removed Record<never, never> from Options in base.ts, full.ts, and minimal.ts; updated exports/imports to use auth/full. - No behavior changes; type signatures are cleaner and more readable. <sup>Written for commit db36c26df47f14c7a18be6640de012367cf9ba8d. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:36:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32898
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?