github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8725] feat(passkey): infer authenticator name from AAGUID with override hook #25074

New Issue
Open
opened 2026-04-15 22:42:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:42:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8725
Author: @mburumaxwell
Created: 3/21/2026
Status: 🔄 Open

Base: next ← Head: suggest-passkey-name

📝 Commits (10+)

  • 8315b2d docs: add missing secret to getSignedCookie and remove misleading comments (#9008)
  • 674b01e chore(docs): add remark-frontmatter (#9015)
  • ba62436 docs: update community adapters and plugins pages (#9014)
  • c8281b5 docs: change community plugin name (#8961)
  • d9d7e16 docs: add @delmaredigital/payload-better-auth to community plugins (#8375)
  • c0f29e3 fix: use INVALID_PASSWORD for all checkPassword failures (#8902)
  • a6d4f41 ci: add one-click changeset commit and unify bot identity (#9019)
  • 48e4f33 fix: endpoint instrumentation to always use route template (#9023)
  • 3b52e03 docs: hide fumadocs toc scroll indicator dot (#9021)
  • 278274a docs: add expo sentinel docs (#9025)

📊 Changes

55 files changed (+2597 additions, -1149 deletions)

View changed files

➕ .changeset/fresh-news-doubt.md (+5 -0)
➕ .changeset/pr-8902.md (+5 -0)
➕ .changeset/three-plums-vanish.md (+5 -0)
📝 .github/workflows/auto-changeset.yml (+186 -2)
📝 .github/workflows/auto-label.yml (+9 -0)
📝 .github/workflows/auto-retarget.yml (+13 -4)
📝 .github/workflows/lock-threads.yml (+10 -0)
📝 .github/workflows/semantic-pull-request.yml (+12 -1)
📝 .gitignore (+5 -0)
📝 demo/electron/package.json (+1 -1)
📝 demo/oidc-client/package.json (+1 -1)
📝 docs/.remarkrc.mjs (+2 -0)
📝 docs/app/blog/[[...slug]]/page.tsx (+22 -1)
📝 docs/app/community/community-client.tsx (+2 -2)
📝 docs/app/globals.css (+9 -0)
📝 docs/components/community-adapters-grid.tsx (+11 -0)
📝 docs/components/community-plugins-table.tsx (+2 -2)
📝 docs/components/landing/hero-readme.tsx (+1 -1)
📝 docs/components/sidebar-content.tsx (+0 -22)
➕ docs/content/blogs/1-6.mdx (+268 -0)

...and 35 more files

📄 Description

This PR adds AAGUID-based passkey labeling during registration

When a user does not provide a name, resolve the stored label using the developer override via getAuthenticatorName and fallback to the built-in best-effort provider suggestion from known AAGUID values

Why

Some ecosystems surface passkey provider names from AAGUID metadata. This improves default naming UX without introducing new DB storage concerns.

References

Passkey AAGUID source: https://github.com/passkeydeveloper/passkey-authenticator-aaguids
ASP.Net Core implementation: https://github.com/dotnet/aspnetcore/pull/65343
Related discussion: https://github.com/better-auth/better-auth/discussions/7912

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8725 **Author:** [@mburumaxwell](https://github.com/mburumaxwell) **Created:** 3/21/2026 **Status:** 🔄 Open **Base:** `next` ← **Head:** `suggest-passkey-name` --- ### 📝 Commits (10+) - [`8315b2d`](https://github.com/better-auth/better-auth/commit/8315b2d12118c41a979c7cafa2019ebadcfc207f) docs: add missing secret to getSignedCookie and remove misleading comments (#9008) - [`674b01e`](https://github.com/better-auth/better-auth/commit/674b01ef163a99fb0cac7f7278d1eaa373da289b) chore(docs): add `remark-frontmatter` (#9015) - [`ba62436`](https://github.com/better-auth/better-auth/commit/ba62436e78bbe2ca531bc83c403293b5d0133629) docs: update community adapters and plugins pages (#9014) - [`c8281b5`](https://github.com/better-auth/better-auth/commit/c8281b51eae99c5adb68a865f2432772e5e512a9) docs: change community plugin name (#8961) - [`d9d7e16`](https://github.com/better-auth/better-auth/commit/d9d7e16fcd3b4f07b6ef771953384b0f70602d4e) docs: add `@delmaredigital/payload-better-auth` to community plugins (#8375) - [`c0f29e3`](https://github.com/better-auth/better-auth/commit/c0f29e329c2f472bbf67106413d7ca29a1c447a4) fix: use `INVALID_PASSWORD` for all `checkPassword` failures (#8902) - [`a6d4f41`](https://github.com/better-auth/better-auth/commit/a6d4f418664f7986d2d2cf716345e333516873ca) ci: add one-click changeset commit and unify bot identity (#9019) - [`48e4f33`](https://github.com/better-auth/better-auth/commit/48e4f33d4b0b11668fba599909a0877a5f34e84a) fix: endpoint instrumentation to always use route template (#9023) - [`3b52e03`](https://github.com/better-auth/better-auth/commit/3b52e0310ba89d6ce3d1e1a86b7601bf453ba75f) docs: hide fumadocs toc scroll indicator dot (#9021) - [`278274a`](https://github.com/better-auth/better-auth/commit/278274aebfe92f7a82b6887c9ca0856f28e4984a) docs: add expo sentinel docs (#9025) ### 📊 Changes **55 files changed** (+2597 additions, -1149 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/fresh-news-doubt.md` (+5 -0) ➕ `.changeset/pr-8902.md` (+5 -0) ➕ `.changeset/three-plums-vanish.md` (+5 -0) 📝 `.github/workflows/auto-changeset.yml` (+186 -2) 📝 `.github/workflows/auto-label.yml` (+9 -0) 📝 `.github/workflows/auto-retarget.yml` (+13 -4) 📝 `.github/workflows/lock-threads.yml` (+10 -0) 📝 `.github/workflows/semantic-pull-request.yml` (+12 -1) 📝 `.gitignore` (+5 -0) 📝 `demo/electron/package.json` (+1 -1) 📝 `demo/oidc-client/package.json` (+1 -1) 📝 `docs/.remarkrc.mjs` (+2 -0) 📝 `docs/app/blog/[[...slug]]/page.tsx` (+22 -1) 📝 `docs/app/community/community-client.tsx` (+2 -2) 📝 `docs/app/globals.css` (+9 -0) 📝 `docs/components/community-adapters-grid.tsx` (+11 -0) 📝 `docs/components/community-plugins-table.tsx` (+2 -2) 📝 `docs/components/landing/hero-readme.tsx` (+1 -1) 📝 `docs/components/sidebar-content.tsx` (+0 -22) ➕ `docs/content/blogs/1-6.mdx` (+268 -0) _...and 35 more files_ </details> ### 📄 Description This PR adds AAGUID-based passkey labeling during registration When a user does not provide a name, resolve the stored label using the developer override via `getAuthenticatorName` and fallback to the built-in best-effort provider suggestion from known AAGUID values ## Why Some ecosystems surface passkey provider names from AAGUID metadata. This improves default naming UX without introducing new DB storage concerns. ## References Passkey AAGUID source: https://github.com/passkeydeveloper/passkey-authenticator-aaguids ASP.Net Core implementation: https://github.com/dotnet/aspnetcore/pull/65343 Related discussion: https://github.com/better-auth/better-auth/discussions/7912 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:42:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?