github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2039] There's no error code for "Too many requests" error. #9019

New Issue
Closed
opened 2026-04-13 04:17:20 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-13 04:17:20 -05:00
Owner
Copy Link

Originally created by @Maqed on GitHub (Mar 28, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2039

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

auth.ts (server):

export const auth = betterAuth({
rateLimit: {
    enabled: true, // Enabled for dev & prod
  },
});

login-form.tsx (client):

function onSubmit(values: z.infer<typeof loginSchema>) {
    startTransition(async () => {
      const { email, password } = values;
      await authClient.signIn.email(
        {
          email,
          password,
        },
        {
          onError: (ctx) => {
            console.log({ errorCode: ctx.error.code }); // returned undefined.
          },
        },
      );
    });
  }

After submitting the form multiple time, the rate limit will work and it will console.log and error.

Current vs. Expected behavior

Current behaviour: No code for the ratelimit error message

Expected behaviour: There should be an error code for the ratelimit error message

What version of Better Auth are you using?

1.2.5

Provide environment information

- OS [Windows: 11]
- Browser [chrome]

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

Additional context

No response

Originally created by @Maqed on GitHub (Mar 28, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2039 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce auth.ts (server): ```ts export const auth = betterAuth({ rateLimit: { enabled: true, // Enabled for dev & prod }, }); ``` login-form.tsx (client): ```tsx function onSubmit(values: z.infer<typeof loginSchema>) { startTransition(async () => { const { email, password } = values; await authClient.signIn.email( { email, password, }, { onError: (ctx) => { console.log({ errorCode: ctx.error.code }); // returned undefined. }, }, ); }); } ``` After submitting the form multiple time, the rate limit will work and it will console.log and error. ### Current vs. Expected behavior Current behaviour: No code for the ratelimit error message Expected behaviour: There should be an error code for the ratelimit error message ### What version of Better Auth are you using? 1.2.5 ### Provide environment information ```bash - OS [Windows: 11] - Browser [chrome] ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript ``` ### Additional context _No response_
GiteaMirror added the lockedbug labels 2026-04-13 04:17:20 -05:00
GiteaMirror commented 2026-04-13 04:17:22 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Mar 30, 2025):

you can use status property for getting the code which is 429 ctx.error.status

<!-- gh-comment-id:2764546913 --> @Kinfe123 commented on GitHub (Mar 30, 2025): you can use status property for getting the code which is 429 ` ctx.error.status `
GiteaMirror commented 2026-04-13 04:17:24 -05:00
Author
Owner
Copy Link

@Maqed commented on GitHub (Mar 30, 2025):

you can use status property for getting the code which is 429 ctx.error.status

I'd prefer using an error code instead of a status because my app is internationalized. Relying on status codes would require extra checks for messages, adding boilerplate. Error codes simplify handling. Here’s my approach:

onError: (ctx) => {
    toast({
      title: tErrors(`${ctx.error.code}.title`),
      description: tErrors(`${ctx.error.code}.description`),
      variant: "destructive",
    });
<!-- gh-comment-id:2764549727 --> @Maqed commented on GitHub (Mar 30, 2025): > you can use status property for getting the code which is 429 ` > ctx.error.status > ` I'd prefer using an error code instead of a status because my app is internationalized. Relying on status codes would require extra checks for messages, adding boilerplate. Error codes simplify handling. Here’s my approach: ```tsx onError: (ctx) => { toast({ title: tErrors(`${ctx.error.code}.title`), description: tErrors(`${ctx.error.code}.description`), variant: "destructive", }); ```
GiteaMirror commented 2026-04-13 04:17:25 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Mar 30, 2025):

one thing i can say is you can prepare some code-status map for those that requires based on the status.

<!-- gh-comment-id:2764559653 --> @Kinfe123 commented on GitHub (Mar 30, 2025): one thing i can say is you can prepare some code-status map for those that requires based on the status.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?