github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #1759] Username plugin is using errors from Two factor plugin #8902

New Issue
Closed
opened 2026-04-13 04:09:05 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 04:09:05 -05:00
Owner
Copy Link

Originally created by @TheYoxy on GitHub (Mar 10, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/1759

Hi,

While looking to use the error codes from Username plugin, I tried to use the errors codes as described here.
When looking, I've seen that the errors used in the username plugin are not the one described inside the plugin and then cannot be referenced by using $ERROR_CODES from the auth instance.

The errors used inside the plugin:
f90581d7ab/packages/better-auth/src/plugins/username/index.ts (L40-L48)

The errors that are returned from the plugin and inferred for $ERROR_CODES
f90581d7ab/packages/better-auth/src/plugins/username/index.ts (L9)
f90581d7ab/packages/better-auth/src/plugins/username/index.ts (L304)

Is that the expected behavior or should the errors described in the plugin ?
(I can open a PR to fix it if needed.)

Originally created by @TheYoxy on GitHub (Mar 10, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/1759 Hi, While looking to use the error codes from Username plugin, I tried to use the errors codes as described [here](https://better-auth.vercel.app/docs/concepts/client#error-codes). When looking, I've seen that the errors used in the username plugin are not the one described inside the plugin and then cannot be referenced by using `$ERROR_CODES` from the `auth` instance. > The errors used inside the plugin: > https://github.com/better-auth/better-auth/blob/f90581d7ab0493fb58d3c2654c326f6f28a684b3/packages/better-auth/src/plugins/username/index.ts#L40-L48 > The errors that are returned from the plugin and inferred for `$ERROR_CODES` > https://github.com/better-auth/better-auth/blob/f90581d7ab0493fb58d3c2654c326f6f28a684b3/packages/better-auth/src/plugins/username/index.ts#L9 > https://github.com/better-auth/better-auth/blob/f90581d7ab0493fb58d3c2654c326f6f28a684b3/packages/better-auth/src/plugins/username/index.ts#L304 Is that the expected behavior or should the errors described in the plugin ? (I can open a PR to fix it if needed.)
GiteaMirror added the locked label 2026-04-13 04:09:05 -05:00
GiteaMirror commented 2026-04-13 04:09:06 -05:00
Author
Owner
Copy Link

@Lukem121 commented on GitHub (Mar 11, 2025):

bump

<!-- gh-comment-id:2714234746 --> @Lukem121 commented on GitHub (Mar 11, 2025): bump
GiteaMirror commented 2026-04-13 04:09:06 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Apr 12, 2025):

fixed

<!-- gh-comment-id:2799040334 --> @Bekacru commented on GitHub (Apr 12, 2025): fixed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8902
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?