github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #6068] [PM-26810] Remove loading dialog flicker on vault data updates #6285

New Issue
Closed
opened 2025-11-27 00:21:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:21:50 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/6068

State: closed
Merged: Yes

🎟️ Tracking

PM-26810

📔 Objective

This commit addresses a UI flicker issue where a loading dialog would briefly appear, or remain visible, when the vault data was being updated in the background during the item export flow.

The handleVaultDataPending function in ReviewExportViewModel was unnecessarily triggering a generic loading dialog. This function is called when vault data is updating (e.g., after a sync), which caused the dialog to flash on the screen or remain due to race-conditions.

The fix removes the call to showLoadingDialog from handleVaultDataPending. A more specific loading message, "Loading vault data...", has been added to the handleVaultDataLoading function to provide better user feedback when the initial data is being fetched. Additionally, a test case was updated to reflect that the loading dialog is not cleared during the pending state.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes
**Original Pull Request:** https://github.com/bitwarden/android/pull/6068 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-26810 ## 📔 Objective This commit addresses a UI flicker issue where a loading dialog would briefly appear, or remain visible, when the vault data was being updated in the background during the item export flow. The `handleVaultDataPending` function in `ReviewExportViewModel` was unnecessarily triggering a generic loading dialog. This function is called when vault data is updating (e.g., after a sync), which caused the dialog to flash on the screen or remain due to race-conditions. The fix removes the call to `showLoadingDialog` from `handleVaultDataPending`. A more specific loading message, "Loading vault data...", has been added to the `handleVaultDataLoading` function to provide better user feedback when the initial data is being fetched. Additionally, a test case was updated to reflect that the loading dialog is not cleared during the pending state. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
GiteaMirror added the pull-request label 2025-11-27 00:21:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#6285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?