github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6285] [MERGED] [PM-29947] Remove ResetMasterPassword property from token response model #43547

New Issue
Closed
opened 2026-04-23 22:11:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 22:11:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6285
Author: @SaintPatrck
Created: 12/19/2025
Status: ✅ Merged
Merged: 12/19/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-29947/remove-reset-master-password-property

📝 Commits (2)

  • 65fb88a [PM-29947] Remove ResetMasterPassword property from token response model
  • 9635b3c Update documentation for GetTokenResponseJson

📊 Changes

4 files changed (+0 additions, -10 deletions)

View changed files

📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+0 -2)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/GetTokenResponseExtensionsTest.kt (+0 -1)
📝 network/src/main/kotlin/com/bitwarden/network/model/GetTokenResponseJson.kt (+0 -5)
📝 network/src/test/kotlin/com/bitwarden/network/service/IdentityServiceTest.kt (+0 -2)

📄 Description

🎟️ Tracking

PM-29947

📔 Objective

Remove the shouldResetMasterPassword field (mapped to "ResetMasterPassword") from the GetTokenResponseJson network model. This property is no longer processed or required in the identity service response handling.

  • Delete the shouldResetMasterPassword property and its serialization annotation from the GetTokenResponseJson data class.
  • Update unit tests in AuthRepositoryTest, GetTokenResponseExtensionsTest, and IdentityServiceTest to remove the shouldResetMasterPassword argument from the GetTokenResponseJson constructor calls.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6285 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 12/19/2025 **Status:** ✅ Merged **Merged:** 12/19/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-29947/remove-reset-master-password-property` --- ### 📝 Commits (2) - [`65fb88a`](https://github.com/bitwarden/android/commit/65fb88aa879a25825244aaa55f9ebc8b6e976095) [PM-29947] Remove ResetMasterPassword property from token response model - [`9635b3c`](https://github.com/bitwarden/android/commit/9635b3c92d5f5bed6e1613a8906292e9e9552426) Update documentation for `GetTokenResponseJson` ### 📊 Changes **4 files changed** (+0 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+0 -2) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/util/GetTokenResponseExtensionsTest.kt` (+0 -1) 📝 `network/src/main/kotlin/com/bitwarden/network/model/GetTokenResponseJson.kt` (+0 -5) 📝 `network/src/test/kotlin/com/bitwarden/network/service/IdentityServiceTest.kt` (+0 -2) </details> ### 📄 Description ## 🎟️ Tracking PM-29947 ## 📔 Objective Remove the `shouldResetMasterPassword` field (mapped to "ResetMasterPassword") from the `GetTokenResponseJson` network model. This property is no longer processed or required in the identity service response handling. - Delete the `shouldResetMasterPassword` property and its serialization annotation from the `GetTokenResponseJson` data class. - Update unit tests in `AuthRepositoryTest`, `GetTokenResponseExtensionsTest`, and `IdentityServiceTest` to remove the `shouldResetMasterPassword` argument from the `GetTokenResponseJson` constructor calls. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 22:11:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#43547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?