[PR #5819] [PM-25394] Sort default user collections by Organization name #6068

New Issue

2025-11-27T00:19:24-06:00

GiteaMirror commented

2025-11-27 00:19:24 -06:00

Original Pull Request: https://github.com/bitwarden/android/pull/5819

State: closed
Merged: Yes

🎟️ Tracking

PM-25394

📔 Objective

Update the sorting logic for CollectionView lists.

Now, DEFAULT_USER_COLLECTION types are sorted by their corresponding organization's name instead of the collection's name.

Other collection types continue to be sorted by their name.

This change applies to the VaultRepositoryImpl when fetching collections.

Tests have been updated to reflect this new sorting behavior.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

**Original Pull Request:** https://github.com/bitwarden/android/pull/5819 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking PM-25394 ## 📔 Objective Update the sorting logic for `CollectionView` lists. Now, `DEFAULT_USER_COLLECTION` types are sorted by their corresponding organization's name instead of the collection's name. Other collection types continue to be sorted by their name. This change applies to the `VaultRepositoryImpl` when fetching collections. Tests have been updated to reflect this new sorting behavior. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes

GiteaMirror added the pull-request label 2025-11-27 00:19:24 -06:00

GiteaMirror closed this issue