[PR #5451] [MERGED] PM-22213: Hide current access count when editing and there is not max access count #5777

New Issue

GiteaMirror · 2025-11-27T00:14:09-06:00

GiteaMirror commented

2025-11-27 00:14:09 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5451
Author: @david-livefront
Created: 6/30/2025
Status: ✅ Merged
Merged: 7/1/2025
Merged by: @david-livefront

Base: main ← Head: PM-22213-current-access-count

📝 Commits (1)

e078647 PM-22213: Hide current access count when editing and there is not max access count

📊 Changes

1 file changed (+21 additions, -9 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt (+21 -9)

📄 Description

🎟️ Tracking

PM-22213

📔 Objective

This PR hides the current access count field when editing a Send and the the maximum access count is 0 (or null).

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5451 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 6/30/2025 **Status:** ✅ Merged **Merged:** 7/1/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-22213-current-access-count` --- ### 📝 Commits (1) - [`e078647`](https://github.com/bitwarden/android/commit/e07864701fde49a43bd9917ad1bdc5ec7a8fd318) PM-22213: Hide current access count when editing and there is not max access count ### 📊 Changes **1 file changed** (+21 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt` (+21 -9) </details> ### 📄 Description ## 🎟️ Tracking [PM-22213](https://bitwarden.atlassian.net/browse/PM-22213) ## 📔 Objective This PR hides the current access count field when editing a Send and the the maximum access count is 0 (or null). ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/9e84ec06-1488-438a-a351-1bb9c7a53beb" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-22213]: https://bitwarden.atlassian.net/browse/PM-22213?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-27 00:14:09 -06:00

GiteaMirror closed this issue