github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #5253] [MERGED] [PM-21336] CI restructuring #1 - Consolidate Crowdin pull and push workflows #5614

New Issue
Closed
opened 2025-11-27 00:10:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:10:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5253
Author: @vvolkgang
Created: 5/23/2025
Status: ✅ Merged
Merged: 5/26/2025
Merged by: @vvolkgang

Base: main ← Head: monorepo/crowdin

📝 Commits (3)

  • 6e8e88f Rename crowdin.yml -> crowdin-bwpm.yml
  • beec405 Update crowdin workflows to handle Authenticator too
  • e736213 Remove old crowdin workflows

📊 Changes

5 files changed (+39 additions, -109 deletions)

View changed files

➖ .github/workflows/crowdin-pull-authenticator.yml (+0 -59)
📝 .github/workflows/crowdin-pull.yml (+21 -11)
➖ .github/workflows/crowdin-push-authenticator.yml (+0 -32)
📝 .github/workflows/crowdin-push.yml (+18 -7)
📝 crowdin-bwpm.yml (+0 -0)

📄 Description

🎟️ Tracking

PM-21336

📔 Objective

Consolidates Password Manager and Authenticator Crowdin workflows. Made some cosmetic changes to the workflow titles and created PRs.

Test runs and PRs:

  1. Pull run
  2. Push run
  3. https://github.com/bitwarden/android/pull/5255
  4. https://github.com/bitwarden/android/pull/5254

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5253 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 5/23/2025 **Status:** ✅ Merged **Merged:** 5/26/2025 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `monorepo/crowdin` --- ### 📝 Commits (3) - [`6e8e88f`](https://github.com/bitwarden/android/commit/6e8e88fc4a156f25c2e6889e5904880f5ba8d211) Rename crowdin.yml -> crowdin-bwpm.yml - [`beec405`](https://github.com/bitwarden/android/commit/beec40594e99e1925c6e03d1f2ae40b7a6d8287a) Update crowdin workflows to handle Authenticator too - [`e736213`](https://github.com/bitwarden/android/commit/e73621340f8938d7bb49db726aa6a2fcc1999bf1) Remove old crowdin workflows ### 📊 Changes **5 files changed** (+39 additions, -109 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/crowdin-pull-authenticator.yml` (+0 -59) 📝 `.github/workflows/crowdin-pull.yml` (+21 -11) ➖ `.github/workflows/crowdin-push-authenticator.yml` (+0 -32) 📝 `.github/workflows/crowdin-push.yml` (+18 -7) 📝 `crowdin-bwpm.yml` (+0 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-21336 ## 📔 Objective Consolidates Password Manager and Authenticator Crowdin workflows. Made some cosmetic changes to the workflow titles and created PRs. Test runs and PRs: 1. Pull [run](https://github.com/bitwarden/android/actions/runs/15207907021) 2. Push [run](https://github.com/bitwarden/android/actions/runs/15207909899) 3. https://github.com/bitwarden/android/pull/5255 4. https://github.com/bitwarden/android/pull/5254 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:10:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5614
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?