github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #5614] [MERGED] [PM-24292] Correct redundant string interpolation #5911

New Issue
Closed
opened 2025-11-27 00:16:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-27 00:16:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5614
Author: @mKoonrad
Created: 7/29/2025
Status: ✅ Merged
Merged: 8/1/2025
Merged by: @SaintPatrck

Base: main ← Head: main

📝 Commits (5)

  • 65a88a5 Unlock with biometrics full string without variable
  • 456451a Remove unnecessary string
  • a9579d1 Capitalize Biometrics string
  • f3e144a Update strings.xml
  • d9e90c7 Merge remote-tracking branch 'origin/main' into fork/mKoonrad/main

📊 Changes

3 files changed (+3 additions, -10 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt (+1 -4)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt (+1 -4)
📝 ui/src/main/res/values/strings.xml (+1 -2)

📄 Description

🎟️ Tracking

Relates to #5459
PM-24292
PM-23236

📔 Objective

Hello (word) 👋 This is my first PR, so I hope I did everything right. I'm not advanced dev, but translator, who want to fix some issues inside code. See more on #5459

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5614 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 8/1/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`65a88a5`](https://github.com/bitwarden/android/commit/65a88a579b76a93872530e5693f17f9462e53e3c) Unlock with biometrics full string without variable - [`456451a`](https://github.com/bitwarden/android/commit/456451a201180b00311d06e34515ee01323ee187) Remove unnecessary string - [`a9579d1`](https://github.com/bitwarden/android/commit/a9579d1578c8b1bae5e0a2ea50fa6434281c72de) Capitalize Biometrics string - [`f3e144a`](https://github.com/bitwarden/android/commit/f3e144a37629fb6f5d71bab999142b186a93fae7) Update strings.xml - [`d9e90c7`](https://github.com/bitwarden/android/commit/d9e90c768031f12201adc2848a6018cafc0c35e5) Merge remote-tracking branch 'origin/main' into fork/mKoonrad/main ### 📊 Changes **3 files changed** (+3 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt` (+1 -4) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt` (+1 -4) 📝 `ui/src/main/res/values/strings.xml` (+1 -2) </details> ### 📄 Description ## 🎟️ Tracking Relates to #5459 PM-24292 PM-23236 ## 📔 Objective Hello (word) 👋 This is my first PR, so I hope I did everything right. I'm not advanced dev, but translator, who want to fix some issues inside code. See more on [#5459](https://github.com/bitwarden/android/issues/5459) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-27 00:16:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5911
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?