github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4846] [MERGED] [PM-13257] Checking if user is navigating from vault before showing prompt for biometrics #5253

New Issue
Closed
opened 2025-11-26 23:56:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:56:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4846
Author: @aj-rosado
Created: 3/11/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @aj-rosado

Base: main ← Head: PM-13257/not-prompt-for-biometrics-on-lock

📝 Commits (7)

  • 80c3a46 Checking if user is navigating from vault before showing prompt for biometrics
  • 3fa3ad1 added missing promptForBiometricsIfAvailable()
  • d85850c Add isUserInitiated on lockVault so that only user triggered locks don't show biometric prompt
  • 905de3d settings isFromLockFlow on VaultUnlockVM state
  • a9496a9 fixed tests
  • 35d0850 Added isUserInitiated parameter to lockVaultForCurrentUser
  • ebcd8ce Clearing isFromLockFlow state on VaultUnlockVM

📊 Changes

23 files changed (+122 additions, -69 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt (+4 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManager.kt (+7 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+9 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt (+11 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModel.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt (+8 -8)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt (+7 -7)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt (+4 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModelTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModelTest.kt (+30 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt (+2 -2)

...and 3 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13257

📔 Objective

User should not be automatically prompted for biometrics when naviting from vault to lock screen. On all other scenarios user should be automatically prompted.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4846 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-13257/not-prompt-for-biometrics-on-lock` --- ### 📝 Commits (7) - [`80c3a46`](https://github.com/bitwarden/android/commit/80c3a46e81d432e1f9c95d954dd54a9d22b7bbe8) Checking if user is navigating from vault before showing prompt for biometrics - [`3fa3ad1`](https://github.com/bitwarden/android/commit/3fa3ad1e13fa699e978d63c295cb840128acdf65) added missing promptForBiometricsIfAvailable() - [`d85850c`](https://github.com/bitwarden/android/commit/d85850c91cd6793b6e5b3ac5525e70e98af89072) Add isUserInitiated on lockVault so that only user triggered locks don't show biometric prompt - [`905de3d`](https://github.com/bitwarden/android/commit/905de3d889f20275d2539666156fa625bfd54ed4) settings isFromLockFlow on VaultUnlockVM state - [`a9496a9`](https://github.com/bitwarden/android/commit/a9496a9175ef0856ce5c1acfb2a1ccb7ed31379e) fixed tests - [`35d0850`](https://github.com/bitwarden/android/commit/35d08500e1f4e2e1327aa320e6c327ca491f49bd) Added isUserInitiated parameter to lockVaultForCurrentUser - [`ebcd8ce`](https://github.com/bitwarden/android/commit/ebcd8ce1fc22e4d4af34a6c3483c8e0a9ea52d00) Clearing isFromLockFlow state on VaultUnlockVM ### 📊 Changes **23 files changed** (+122 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt` (+4 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManager.kt` (+7 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+9 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModel.kt` (+11 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModel.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/VerificationCodeViewModel.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt` (+8 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt` (+7 -7) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt` (+4 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModelTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/vaultunlock/VaultUnlockViewModelTest.kt` (+30 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/SendViewModelTest.kt` (+2 -2) _...and 3 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13257 ## 📔 Objective User should not be automatically prompted for biometrics when naviting from vault to lock screen. On all other scenarios user should be automatically prompted. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:56:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?