github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4302] [MERGED] [PM-13831] Add copy button identity and note fields #4846

New Issue
Closed
opened 2025-11-26 23:50:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:50:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4302
Author: @aj-rosado
Created: 11/14/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @aj-rosado

Base: main ← Head: PM-13831/add-copy-button-cipher-fields

📝 Commits (10+)

  • b5993a4 Add copy buttons to identity items
  • 54057f3 Add copy buttons to note fields
  • 7b9d8dd Merge branch 'main' into PM-13831/add-copy-button-cipher-fields
  • 8fd0bf3 addressing pr comments
  • 15a23ec removing unnecessary masterpassword reprompt check on copy event for identity and notes
  • 59a3d65 Added missing tests and corrected identity test names on VaultItemScreenTest
  • 411e76a readded copy notes tag
  • cbeec90 Corrected code on VaultItemViewModel
  • fa472b6 Merge branch 'main' into PM-13831/add-copy-button-cipher-fields
  • c2c61a4 Fix copy tests on VaultItemViewModelTest

📊 Changes

11 files changed (+798 additions, -58 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt (+11 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt (+84 -52)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt (+12 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt (+12 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt (+172 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt (+4 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultIdentityItemTypeHandlers.kt (+59 -0)
📝 app/src/main/res/values/strings.xml (+8 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt (+247 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt (+183 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13831

📔 Objective

Adding easy access copy button for the identity fields and notes fields to match other clients.

📸 Screenshots

View identity cipher screen
View identity cipher screen

View login cipher screen
View login cipher screen

View card cipher screen
View card cipher screen

View secure note cipher screen
View secure note cipher screen

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4302 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-13831/add-copy-button-cipher-fields` --- ### 📝 Commits (10+) - [`b5993a4`](https://github.com/bitwarden/android/commit/b5993a4761a84d3093b88d114cc54f3c2f1c81d1) Add copy buttons to identity items - [`54057f3`](https://github.com/bitwarden/android/commit/54057f3d79bd7ed43cdadfff2ab9cf22dd01d25b) Add copy buttons to note fields - [`7b9d8dd`](https://github.com/bitwarden/android/commit/7b9d8dd394ea9c549d35a1db01bb443e16479f72) Merge branch 'main' into PM-13831/add-copy-button-cipher-fields - [`8fd0bf3`](https://github.com/bitwarden/android/commit/8fd0bf3e29dcbc63b545d94ab39df86418954bd6) addressing pr comments - [`15a23ec`](https://github.com/bitwarden/android/commit/15a23eca04fd3f2bab7d8718ed2259214d284f4f) removing unnecessary masterpassword reprompt check on copy event for identity and notes - [`59a3d65`](https://github.com/bitwarden/android/commit/59a3d65200d13ec2fe85962b219be088998a35c5) Added missing tests and corrected identity test names on VaultItemScreenTest - [`411e76a`](https://github.com/bitwarden/android/commit/411e76a582a13e8c862aa45b0e6c512dd9d00dd1) readded copy notes tag - [`cbeec90`](https://github.com/bitwarden/android/commit/cbeec9078e108881d0adbda3cd02d23c1aa21699) Corrected code on VaultItemViewModel - [`fa472b6`](https://github.com/bitwarden/android/commit/fa472b60473dc4a45f68f459c6f6b140e5ee04e7) Merge branch 'main' into PM-13831/add-copy-button-cipher-fields - [`c2c61a4`](https://github.com/bitwarden/android/commit/c2c61a40f728e9c9af66e33e5a49efd6b53e8fcb) Fix copy tests on VaultItemViewModelTest ### 📊 Changes **11 files changed** (+798 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt` (+11 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt` (+84 -52) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt` (+12 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt` (+12 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt` (+172 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt` (+4 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultIdentityItemTypeHandlers.kt` (+59 -0) 📝 `app/src/main/res/values/strings.xml` (+8 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt` (+247 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModelTest.kt` (+183 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13831 ## 📔 Objective Adding easy access copy button for the identity fields and notes fields to match other clients. ## 📸 Screenshots **View identity cipher screen** <img width="314" alt="View identity cipher screen" src="https://github.com/user-attachments/assets/0bfac4f1-f40e-46a6-81b4-0a393f000e52"> **View login cipher screen** <img width="314" alt="View login cipher screen" src="https://github.com/user-attachments/assets/8522e5e9-f0ee-456f-923d-03edcab20b34"> **View card cipher screen** <img width="314" alt="View card cipher screen" src="https://github.com/user-attachments/assets/b9490333-37c2-4a02-b2ad-ce5cf2e22a03"> **View secure note cipher screen** <img width="314" alt="View secure note cipher screen" src="https://github.com/user-attachments/assets/24e09a84-a37f-4e2d-8387-4c3288a17110"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:50:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4846
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?