github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3084] [CLOSED] [PM-6846] Added spaced card nubmer to the card view #52231

New Issue
Closed
opened 2026-05-01 16:07:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-01 16:07:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3084
Author: @moalhaddar
Created: 3/15/2024
Status: ❌ Closed

Base: main ← Head: fix/spaced-card-number-view

📝 Commits (10+)

  • 8bc2df6 Autosync the updated translations (#2555)
  • eeb634e PM-1798 Added accessibility names on entries on cipher add (#2550)
  • 1c13ed9 [PS-2558] Mobile Automation - Starting automationIDs additions to our codebase (#2558)
  • 3b087c5 PM-1076 added warning on unlocking iOS extensions when the kdf type is argon2id and the memory is higher than 48MB, to let the user know that unlocking might crash the extension (#2560)
  • dcf9acb Autosync the updated translations (#2562)
  • f604da1 add more comment to missing actions (#2567)
  • 04e30c2 Update F-Droid listing author name (#2501)
  • 1332ef7 Enhancement to login field detection for Android autofill (#2561)
  • 98705e4 PM-2575 Fixed extension freeze when using the return button on the keyboard when unlocking the extension. Also added way to prevent multiple executions of checking the password and logging exceptions. (#2568)
  • 52843b4 [PM-2544] Adding AutomationIDs for CipherAddEditViewPage elements (#2564)

📊 Changes

2 files changed (+14 additions, -1 deletions)

View changed files

📝 src/Core/Models/View/CardView.cs (+13 -0)
📝 src/Core/Pages/Vault/CipherDetailsPage.xaml (+1 -1)

📄 Description

Type of change

  • [✅] Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The card number in bitwarden mobile is not spaced in the mobile view. This pull request fixes the view such that the number is spaced in splits of 4.

Code changes

A new property in the CardView named SpacedNumber was added that adds a space in every 4 digits from the "CardView.Number"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3084 **Author:** [@moalhaddar](https://github.com/moalhaddar) **Created:** 3/15/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/spaced-card-number-view` --- ### 📝 Commits (10+) - [`8bc2df6`](https://github.com/bitwarden/android/commit/8bc2df6c8afb723d39c72163f08ef0f4bf191433) Autosync the updated translations (#2555) - [`eeb634e`](https://github.com/bitwarden/android/commit/eeb634e69886be2ff48f1776965268bb86db8483) PM-1798 Added accessibility names on entries on cipher add (#2550) - [`1c13ed9`](https://github.com/bitwarden/android/commit/1c13ed9895c3d141cfeef376416709e41dc25812) [PS-2558] Mobile Automation - Starting automationIDs additions to our codebase (#2558) - [`3b087c5`](https://github.com/bitwarden/android/commit/3b087c50ae14d8b8a7b2f560fe2b46f060b1de71) PM-1076 added warning on unlocking iOS extensions when the kdf type is argon2id and the memory is higher than 48MB, to let the user know that unlocking might crash the extension (#2560) - [`dcf9acb`](https://github.com/bitwarden/android/commit/dcf9acb51c601e7e336cdd0c14cce2ea606ff7bf) Autosync the updated translations (#2562) - [`f604da1`](https://github.com/bitwarden/android/commit/f604da13a1cedb801a2758237f8998094615d53e) add more comment to missing actions (#2567) - [`04e30c2`](https://github.com/bitwarden/android/commit/04e30c21462fb379cf57244dff700fd65a632cdb) Update F-Droid listing author name (#2501) - [`1332ef7`](https://github.com/bitwarden/android/commit/1332ef7b433e8645eecfdeefdc9fe483adec5a7d) Enhancement to login field detection for Android autofill (#2561) - [`98705e4`](https://github.com/bitwarden/android/commit/98705e443f321411dd3b7c8d54581fe4462cc3c5) PM-2575 Fixed extension freeze when using the return button on the keyboard when unlocking the extension. Also added way to prevent multiple executions of checking the password and logging exceptions. (#2568) - [`52843b4`](https://github.com/bitwarden/android/commit/52843b4181e05ac4bbfb60a7431fa72537f92228) [PM-2544] Adding AutomationIDs for CipherAddEditViewPage elements (#2564) ### 📊 Changes **2 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/View/CardView.cs` (+13 -0) 📝 `src/Core/Pages/Vault/CipherDetailsPage.xaml` (+1 -1) </details> ### 📄 Description ## Type of change - [✅] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The card number in bitwarden mobile is not spaced in the mobile view. This pull request fixes the view such that the number is spaced in splits of 4. ## Code changes A new property in the CardView named SpacedNumber was added that adds a space in every 4 digits from the "CardView.Number" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-01 16:07:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#52231
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?