github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #739] [MERGED] Make callbacks from UI thread. #2564

New Issue
Closed
opened 2025-11-26 23:21:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/739
Author: @oldium
Created: 2/23/2020
Status: ✅ Merged
Merged: 2/24/2020
Merged by: @kspearrin

Base: master ← Head: fix-callback-thread

📝 Commits (1)

  • d3c33b0 Make callbacks from UI thread.

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+3 -3)

📄 Description

The code expects to be called form UI thread, but it looks like JavaScript
callbacks are not. Switch to UI thread when invoking a callback.

This is a better fix than #738, because this fixes the whole callback thread issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/739 **Author:** [@oldium](https://github.com/oldium) **Created:** 2/23/2020 **Status:** ✅ Merged **Merged:** 2/24/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `fix-callback-thread` --- ### 📝 Commits (1) - [`d3c33b0`](https://github.com/bitwarden/android/commit/d3c33b0cfd919aa191624d0c397e90170aa8152e) Make callbacks from UI thread. ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+3 -3) </details> ### 📄 Description The code expects to be called form UI thread, but it looks like JavaScript callbacks are not. Switch to UI thread when invoking a callback. This is a better fix than #738, because this fixes the whole callback thread issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?