github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1737] [MERGED] Add dotnet-format tool #3084

New Issue
Closed
opened 2025-11-26 23:28:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1737
Author: @Hinton
Created: 1/31/2022
Status: ✅ Merged
Merged: 4/26/2022
Merged by: @Hinton

Base: master ← Head: feature/format

📝 Commits (4)

  • 252bc71 Add dotnet-tools.json
  • a499deb Add workflow
  • 6e59ae5 Disable format check
  • ccdab83 Merge branch 'master' of github.com:bitwarden/mobile into feature/format

📊 Changes

3 files changed (+21 additions, -0 deletions)

View changed files

➕ .config/dotnet-tools.json (+12 -0)
📝 .editorconfig (+1 -0)
📝 .github/workflows/build.yml (+8 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

Adds required configuration to run dotnet format. Since we are primarily using .NET 5, we rely on the tool variant, in the future the format command is baked into dotnet.

dotnet tool restore to install the tools.
dotnet tool run dotnet-format to apply the formatting rules

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1737 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 4/26/2022 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `feature/format` --- ### 📝 Commits (4) - [`252bc71`](https://github.com/bitwarden/android/commit/252bc718b94186e5aa8cfea1f1da39ec3283ce0e) Add dotnet-tools.json - [`a499deb`](https://github.com/bitwarden/android/commit/a499deb1df29d7c2cbfe88c6e309c0bb6785aca2) Add workflow - [`6e59ae5`](https://github.com/bitwarden/android/commit/6e59ae50f07ec608b4679b7a1fab7bf87bc77831) Disable format check - [`ccdab83`](https://github.com/bitwarden/android/commit/ccdab83c0e686a4d38ec37b2236d6e32d6a6a502) Merge branch 'master' of github.com:bitwarden/mobile into feature/format ### 📊 Changes **3 files changed** (+21 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.config/dotnet-tools.json` (+12 -0) 📝 `.editorconfig` (+1 -0) 📝 `.github/workflows/build.yml` (+8 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Adds required configuration to run dotnet format. Since we are primarily using .NET 5, we rely on the tool variant, in the future the format command is baked into dotnet. `dotnet tool restore` to install the tools. `dotnet tool run dotnet-format` to apply the formatting rules ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?