github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4006] [MERGED] [PM-9363] Disable cipher key encryption for older server versions #4604

New Issue
Closed
opened 2025-11-26 23:47:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:47:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4006
Author: @mpbw2
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @mpbw2

Base: main ← Head: pm-9363/cipher-key-server-version

📝 Commits (5)

📊 Changes

3 files changed (+108 additions, -1 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerImpl.kt (+9 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/util/ServerVersionUtils.kt (+51 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt (+48 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9363

📔 Objective

Disable cipher key encryption in SDK if server version < 2024.2.0

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4006 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `main` ← **Head:** `pm-9363/cipher-key-server-version` --- ### 📝 Commits (5) - [`7ab88ee`](https://github.com/bitwarden/android/commit/7ab88ee5f12168afe90001841eeb051176439f4b) Disable cipher key encryption for older server versions - [`95dfe5e`](https://github.com/bitwarden/android/commit/95dfe5e65431452ff59b61d256579f82d379a5cd) tweaks and simple version tests - [`ecf6407`](https://github.com/bitwarden/android/commit/ecf64073a194541a041c345c49c81cc20258959b) adjustments - [`e6204b1`](https://github.com/bitwarden/android/commit/e6204b1ad4e64372bcd4cb47f67a2e0803777c8c) adjustments - [`f47edb3`](https://github.com/bitwarden/android/commit/f47edb37d66c31fa310d4d9a6afa465bf6d0bbec) adjustments ### 📊 Changes **3 files changed** (+108 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerImpl.kt` (+9 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/util/ServerVersionUtils.kt` (+51 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt` (+48 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-9363 ## 📔 Objective Disable cipher key encryption in SDK if server version < 2024.2.0 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:47:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?