github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4604] [MERGED] PM-17074-PM-17802 - Send Screen Design Updates #5065

New Issue
Closed
opened 2025-11-26 23:53:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:53:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4604
Author: @phil-livefront
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @phil-livefront

Base: main ← Head: phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit

📝 Commits (10+)

  • cef4be0 PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit
  • 02057fe fix tests
  • 98c9fbe fix lint issues with imports
  • 6e6de69 Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit
  • 3ddd4ce PR comments
  • 427f189 Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit
  • 9584eca revert unnecessary change in view model
  • 920f7c0 Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit
  • 5c40721 remove expiration related handlers
  • 26fc8da PR comments

📊 Changes

7 files changed (+109 additions, -500 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt (+85 -153)
➖ app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendExpirationDateChooser.kt (+0 -139)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModel.kt (+0 -22)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt (+2 -10)
📝 app/src/main/res/values/strings.xml (+5 -7)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendScreenTest.kt (+17 -128)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt (+0 -41)

📄 Description

🎟️ Tracking

PM-17074 - Update send field label
PM-17075 - Add eyebrow text label
PM-17076 - Update Send name
PM-17077 - Move Send deletion date
PM-17079 - Remove Send expiration date field
PM-17080 - Update notes label to "Private notes"
PM-17081 - Change "New Password" subtext
PM-17082 - Remove "Deactivate this Send" Toggle

📔 Objective

  • Update the Send screen to match the new reskin designs. Figma link here
  • I know this seems like a ton of tickets but they were broken up super small so this felt like the best use of develop/PR time. If you want me to break them up, I am happy to do so but since it was mostly isolated to the Send screen specifics, it felt safer to me. There are some more tickets needed to complete this but they were a bit more complex so I kept them out of this PR.

📸 Screenshots

send design changes.webm

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4604 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit` --- ### 📝 Commits (10+) - [`cef4be0`](https://github.com/bitwarden/android/commit/cef4be07099a25aa6d69073054e16285d70de721) PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit - [`02057fe`](https://github.com/bitwarden/android/commit/02057fe20adfb246c4d99fbda6b7cfabf42f7c41) fix tests - [`98c9fbe`](https://github.com/bitwarden/android/commit/98c9fbef981a5623ae49a70a0e56583afecbc149) fix lint issues with imports - [`6e6de69`](https://github.com/bitwarden/android/commit/6e6de699d06a331c4acc6dfbea024ab6bbdd64ad) Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit - [`3ddd4ce`](https://github.com/bitwarden/android/commit/3ddd4ce7ce4c9f964af00f62c974b5a167c776f3) PR comments - [`427f189`](https://github.com/bitwarden/android/commit/427f1894a61926617fbff405226623d1429131ef) Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit - [`9584eca`](https://github.com/bitwarden/android/commit/9584eca5ab9b6307877c94a75eba14506b3e27e8) revert unnecessary change in view model - [`920f7c0`](https://github.com/bitwarden/android/commit/920f7c0a0db0240e21dab7c1b1290169724956ed) Merge branch 'main' into phil/PM-17075-PM-17075-PM-17076-PM-17076-PM-17078-PM-17079-PM-17080-PM-17081-PM-17082-send-design-audit - [`5c40721`](https://github.com/bitwarden/android/commit/5c4072176d44d45ed66e53e9afb64016fd9872d5) remove expiration related handlers - [`26fc8da`](https://github.com/bitwarden/android/commit/26fc8da38e792178b375d6fa7ad50b08a81a4a79) PR comments ### 📊 Changes **7 files changed** (+109 additions, -500 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt` (+85 -153) ➖ `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendExpirationDateChooser.kt` (+0 -139) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModel.kt` (+0 -22) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt` (+2 -10) 📝 `app/src/main/res/values/strings.xml` (+5 -7) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendScreenTest.kt` (+17 -128) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendViewModelTest.kt` (+0 -41) </details> ### 📄 Description ## 🎟️ Tracking [PM-17074](https://bitwarden.atlassian.net/browse/PM-17074) - Update send field label [PM-17075](https://bitwarden.atlassian.net/browse/PM-17075) - Add eyebrow text label [PM-17076](https://bitwarden.atlassian.net/browse/PM-17076) - Update Send name [PM-17077](https://bitwarden.atlassian.net/browse/PM-17077) - Move Send deletion date [PM-17079](https://bitwarden.atlassian.net/browse/PM-17079) - Remove Send expiration date field [PM-17080](https://bitwarden.atlassian.net/browse/PM-17080) - Update notes label to "Private notes" [PM-17081](https://bitwarden.atlassian.net/browse/PM-17081) - Change "New Password" subtext [PM-17082](https://bitwarden.atlassian.net/browse/PM-17082) - Remove "Deactivate this Send" Toggle ## 📔 Objective - Update the Send screen to match the new reskin designs. Figma link [here](https://www.figma.com/design/gAE9D9OP2zOuVU7aSiIbHy/Bitwarden-Android-Mobile-App-Reskin---V3-(current)?node-id=59558-60553&p=f&m=dev) - I know this seems like a ton of tickets but they were broken up super small so this felt like the best use of develop/PR time. If you want me to break them up, I am happy to do so but since it was mostly isolated to the Send screen specifics, it felt safer to me. There are some more tickets needed to complete this but they were a bit more complex so I kept them out of this PR. ## 📸 Screenshots [send design changes.webm](https://github.com/user-attachments/assets/f9d8252e-73db-48af-aad8-ea746d53af6e) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-17074]: https://bitwarden.atlassian.net/browse/PM-17074?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17075]: https://bitwarden.atlassian.net/browse/PM-17075?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17076]: https://bitwarden.atlassian.net/browse/PM-17076?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17077]: https://bitwarden.atlassian.net/browse/PM-17077?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17078]: https://bitwarden.atlassian.net/browse/PM-17078?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17079]: https://bitwarden.atlassian.net/browse/PM-17079?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17080]: https://bitwarden.atlassian.net/browse/PM-17080?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17081]: https://bitwarden.atlassian.net/browse/PM-17081?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-17082]: https://bitwarden.atlassian.net/browse/PM-17082?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:53:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5065
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?