github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3071] [PM-6751]Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator #4006

New Issue
Closed
opened 2025-11-26 23:39:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:33 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3071

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There's a NullPointerException ocurring in WebAuthenticatorIntermediateActivity.
This is likely related with WebAuthenticatorCallbackActivity in Android.
As explained in the Microsoft Docs when using this WebAuthenticator on Android we need to add the appropriate query.
This might be the cause of the bug.

<queries>
    <intent>
        <action android:name="android.support.customtabs.action.CustomTabsService" />
    </intent>
</queries>

Code changes

Added the query intent for CustomTabs as it might fix the exception that is occurring in Android WebAuthenticator.

  • AndroidManifest.xml: Added the query

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3071 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective There's a `NullPointerException` ocurring in `WebAuthenticatorIntermediateActivity`. This is likely related with `WebAuthenticatorCallbackActivity` in Android. As explained in the [Microsoft Docs](https://learn.microsoft.com/en-us/dotnet/maui/platform-integration/communication/authentication?view=net-maui-8.0&tabs=android) when using this WebAuthenticator on Android we need to add the appropriate query. This might be the cause of the bug. ``` <queries> <intent> <action android:name="android.support.customtabs.action.CustomTabsService" /> </intent> </queries> ``` ## Code changes Added the query intent for CustomTabs as it might fix the exception that is occurring in Android WebAuthenticator. * **AndroidManifest.xml:** Added the query ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?