github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1721] [MERGED] Account Deletion on SSO with CME #3071

New Issue
Closed
opened 2025-11-26 23:27:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1721
Author: @fedemkr
Created: 1/18/2022
Status: ✅ Merged
Merged: 1/24/2022
Merged by: @fedemkr

Base: master ← Head: account-delete-sso-cme

📝 Commits (5)

  • 2be074f WIP Added Verification Code page and a verification flow helper to coordinate things
  • fc3dde0 Improved Verification Code page verification flow helper and fix some issues, also added flag ApiService to choose whether to logout on Unanuthorized
  • 77b2793 Improved Verification Code page UI/UX verification flow helper and fix some issues and made some cleanups
  • 75ebd0f Fix spelling
  • 754dd78 Merge branch 'master' into account-delete-sso-cme

📊 Changes

12 files changed (+622 additions, -24 deletions)

View changed files

📝 src/Android/MainApplication.cs (+16 -0)
📝 src/App/App.csproj (+2 -0)
📝 src/App/Pages/Accounts/DeleteAccountViewModel.cs (+47 -16)
➕ src/App/Pages/Accounts/VerificationCodePage.xaml (+99 -0)
➕ src/App/Pages/Accounts/VerificationCodePage.xaml.cs (+49 -0)
➕ src/App/Pages/Accounts/VerificationCodeViewModel.cs (+176 -0)
📝 src/App/Resources/AppResources.Designer.cs (+36 -0)
📝 src/App/Resources/AppResources.resx (+18 -0)
➕ src/App/Utilities/VerificationActionsFlowHelper.cs (+147 -0)
📝 src/Core/Abstractions/IApiService.cs (+1 -1)
📝 src/Core/Services/ApiService.cs (+15 -7)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+16 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added possibility to delete an account that was logging on SSO with CME. Also, added a VerificationCodePage that can be reused when we need action code verification.

Code changes

  • VerificationActionsFlowHelper.cs: Added this helper that interacts with the different verifications (master password/verification code) and the actions to perform (like delete account)
  • DeleteAccountViewModel.cs: Modified to adapt it to the VerificationActionsFlowHelper
  • VerificationCodePage.xaml/ViewModel.cs: Added this view to reuse it when we need verification code with actions
  • ApiService: Added possibility of avoid logging out when HttpStatusCode.Unauthorized

Testing requirements

  • Perform same tests as in #1621
  • Test that an account logged in on SSO with CME can also be deleted with the Verification Code

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1721 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 1/18/2022 **Status:** ✅ Merged **Merged:** 1/24/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `account-delete-sso-cme` --- ### 📝 Commits (5) - [`2be074f`](https://github.com/bitwarden/android/commit/2be074f62124dfa50a2d553ddfc3b7f23e9f5478) WIP Added Verification Code page and a verification flow helper to coordinate things - [`fc3dde0`](https://github.com/bitwarden/android/commit/fc3dde0e7b19bcf1b470e1cc8c9cc84aeccb4cfe) Improved Verification Code page verification flow helper and fix some issues, also added flag ApiService to choose whether to logout on Unanuthorized - [`77b2793`](https://github.com/bitwarden/android/commit/77b2793da81d57d592b8e0d9950d4c36fc9e18fa) Improved Verification Code page UI/UX verification flow helper and fix some issues and made some cleanups - [`75ebd0f`](https://github.com/bitwarden/android/commit/75ebd0f9d683fc6e3eb2955d85e3585f6f708962) Fix spelling - [`754dd78`](https://github.com/bitwarden/android/commit/754dd7890be114907b0cf1fa5f8bef2b3c7d7268) Merge branch 'master' into account-delete-sso-cme ### 📊 Changes **12 files changed** (+622 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainApplication.cs` (+16 -0) 📝 `src/App/App.csproj` (+2 -0) 📝 `src/App/Pages/Accounts/DeleteAccountViewModel.cs` (+47 -16) ➕ `src/App/Pages/Accounts/VerificationCodePage.xaml` (+99 -0) ➕ `src/App/Pages/Accounts/VerificationCodePage.xaml.cs` (+49 -0) ➕ `src/App/Pages/Accounts/VerificationCodeViewModel.cs` (+176 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+36 -0) 📝 `src/App/Resources/AppResources.resx` (+18 -0) ➕ `src/App/Utilities/VerificationActionsFlowHelper.cs` (+147 -0) 📝 `src/Core/Abstractions/IApiService.cs` (+1 -1) 📝 `src/Core/Services/ApiService.cs` (+15 -7) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+16 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Added possibility to delete an account that was logging on SSO with CME. Also, added a `VerificationCodePage` that can be reused when we need action code verification. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **VerificationActionsFlowHelper.cs:** Added this helper that interacts with the different verifications (master password/verification code) and the actions to perform (like delete account) * **DeleteAccountViewModel.cs:** Modified to adapt it to the `VerificationActionsFlowHelper` * **VerificationCodePage.xaml/ViewModel.cs:** Added this view to reuse it when we need verification code with actions * **ApiService:** Added possibility of avoid logging out when `HttpStatusCode.Unauthorized` ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> * Perform same tests as in #1621 * Test that an account logged in on SSO with CME can also be deleted with the Verification Code ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [X] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?