github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3031] [PM-5912] Fix for some iOS buttons not having the correct height and corner radius #3975

New Issue
Closed
opened 2025-11-26 23:39:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:08 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3031

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Some buttons on iOS don't have the correct Height and Corner Radius

Code changes

Xamarin Forms doesn't seem to have the same defaults for Buttons than MAUI on iOS.
To fix these issues I added default min height and corner radius for iOS buttons.
Also removed incorrect style class from one button.

  • iOS.xaml: Added default CornerRadius and MinHeightRequest for iOS Buttons and removed redundant properties from other Button styles that are based from default one.
  • LoginPasswordlessPage.xaml: Removed incorrect class

Screenshots

Before After
Device_Aprove_Before Device_Aprove_After
Cipher_Add_Edit_Before Cipher_Add_Edit_After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3031 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Some buttons on iOS don't have the correct Height and Corner Radius ## Code changes Xamarin Forms doesn't seem to have the same defaults for Buttons than MAUI on iOS. To fix these issues I added default min height and corner radius for iOS buttons. Also removed incorrect style class from one button. * **iOS.xaml:** Added default CornerRadius and MinHeightRequest for iOS Buttons and removed redundant properties from other Button styles that are based from default one. * **LoginPasswordlessPage.xaml:** Removed incorrect class ## Screenshots Before | After :-------------------------:|:-------------------------: <img width="768" alt="Device_Aprove_Before" src="https://github.com/bitwarden/mobile/assets/2824952/c3264a18-f980-4414-b3af-0f8b93879b24"> | <img width="768" alt="Device_Aprove_After" src="https://github.com/bitwarden/mobile/assets/2824952/dc23ea5a-4ac5-488e-97f8-41f89de91d4c"> <img width="768" alt="Cipher_Add_Edit_Before" src="https://github.com/bitwarden/mobile/assets/2824952/505a07fe-262a-4ab0-abcf-d8068cfdc1e7"> | <img width="768" alt="Cipher_Add_Edit_After" src="https://github.com/bitwarden/mobile/assets/2824952/b328fc5f-2c30-493c-8116-f63e7289b2b7"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3975
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?