github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3975] [MERGED] [PM-12279] Update SDK reference and use Origin.Android on Fido2Credential #4575

New Issue
Closed
opened 2025-11-26 23:46:47 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:47 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3975
Author: @aj-rosado
Created: 9/26/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @aj-rosado

Base: main ← Head: PM-12279/update-sdk-reference

📝 Commits (4)

  • 48abeee Updated SDK reference and updated the Fido2Credential to use new Android.Origin class
  • 0acb0ce improved readability
  • 62e9c54 Added tests to new error scenarios on Fido2CredentialManager
  • 833e9fe Changed assertTrue to assertEquals on Fide2CredentialManagerTests

📊 Changes

6 files changed (+128 additions, -17 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt (+26 -2)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/AuthenticateFido2CredentialRequest.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/RegisterFido2CredentialRequest.kt (+2 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt (+83 -8)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt (+13 -2)
📝 gradle/libs.versions.toml (+1 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12279

📔 Objective

Update the SDK reference to fix EncString type downgrades
Also changed Fido2Credential in order to work with the new Origin.Android object added on https://github.com/bitwarden/sdk/pull/1042

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3975 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/26/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-12279/update-sdk-reference` --- ### 📝 Commits (4) - [`48abeee`](https://github.com/bitwarden/android/commit/48abeee87ddfe966464205b0253b9994eaf4bd03) Updated SDK reference and updated the Fido2Credential to use new Android.Origin class - [`0acb0ce`](https://github.com/bitwarden/android/commit/0acb0ce9a00a131462db66a450c2eb4e949cd6bc) improved readability - [`62e9c54`](https://github.com/bitwarden/android/commit/62e9c5427808b630a9e0e88b56deeaf89a72a37c) Added tests to new error scenarios on Fido2CredentialManager - [`833e9fe`](https://github.com/bitwarden/android/commit/833e9fe5ca6dc60ce0b300fbcc798a9bd0f1ea28) Changed assertTrue to assertEquals on Fide2CredentialManagerTests ### 📊 Changes **6 files changed** (+128 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerImpl.kt` (+26 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/AuthenticateFido2CredentialRequest.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/RegisterFido2CredentialRequest.kt` (+2 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/manager/Fido2CredentialManagerTest.kt` (+83 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceTest.kt` (+13 -2) 📝 `gradle/libs.versions.toml` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-12279 ## 📔 Objective Update the SDK reference to fix EncString type downgrades Also changed Fido2Credential in order to work with the new Origin.Android object added on https://github.com/bitwarden/sdk/pull/1042 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:47 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?