github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1653] [MERGED] Bug/cme autofill unlock #3031

New Issue
Closed
opened 2025-11-26 23:27:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1653
Author: @jlf0dev
Created: 11/19/2021
Status: ✅ Merged
Merged: 11/19/2021
Merged by: @jlf0dev

Base: master ← Head: bug/cme-autofill-unlock

📝 Commits (4)

  • b7cd883 Show SSO login if using key-connector without bio or pin
  • 2ecbc4b remove additional call to enable biometrics and change method name
  • 97bbf4a allow sso for first biometric authenitcation
  • 5c57628 Merge branch 'master' into bug/cme-autofill-unlock

📊 Changes

1 file changed (+9 additions, -5 deletions)

View changed files

📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+9 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Autofill wasn't prompting for SSO on the initial use of biometric authentication. This change checks if the biometricIntegrityKey is false on load and prompts for SSO if so.

Code changes

  • src/iOS.Core/Controllers/LockPasswordViewController.cs: add check for biometricIntegrityValid while prompting for SSO

Testing requirements

  • Autofill functionality with key connector

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1653 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/cme-autofill-unlock` --- ### 📝 Commits (4) - [`b7cd883`](https://github.com/bitwarden/android/commit/b7cd883c421b57cf12c499ede6625e0c4e90a7de) Show SSO login if using key-connector without bio or pin - [`2ecbc4b`](https://github.com/bitwarden/android/commit/2ecbc4b2c155fbd927af5558fb677b1d34f37821) remove additional call to enable biometrics and change method name - [`97bbf4a`](https://github.com/bitwarden/android/commit/97bbf4af70422dd0d676e91245dfc6448b8c2245) allow sso for first biometric authenitcation - [`5c57628`](https://github.com/bitwarden/android/commit/5c576282923aa5bca06645b4701aabf0f65fb27e) Merge branch 'master' into bug/cme-autofill-unlock ### 📊 Changes **1 file changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+9 -5) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Autofill wasn't prompting for SSO on the initial use of biometric authentication. This change checks if the `biometricIntegrityKey` is false on load and prompts for SSO if so. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/iOS.Core/Controllers/LockPasswordViewController.cs:** add check for `biometricIntegrityValid` while prompting for SSO ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Autofill functionality with key connector ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?