github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2460] [MERGED] [PM-1615] Fix cipher options not working in lists due to binding failing #3578

New Issue
Closed
opened 2025-11-26 23:34:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2460
Author: @fedemkr
Created: 3/31/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @fedemkr

Base: master ← Head: PM-1615-fix-cipher-options-not-working-2

📝 Commits (2)

  • 7147adb PM-1615 Fix cipher options not working in lists due to binding failing due to type mismatch. Updated GroupingsPageViewModel to new way of calling as well
  • 29c537e Merge branch 'master' into PM-1615-fix-cipher-options-not-working-2

📊 Changes

2 files changed (+8 additions, -13 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs (+4 -3)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+4 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix cipher options not working on lists due to binding failing.

#2456 again so it gets tested before merged to master

Code changes

  • CipherViewCell: Changed type of the ButtonCommand from Command<CipherView> to ICommand to make it more generic and easy to bind to any type of command in the ViewModel. This was causing the issue due to the change on the ViewModel to an AsyncCommand<...>
  • GroupingsPageViewModel: Updated to use the AsyncCommand<...> as in the other places.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2460 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-1615-fix-cipher-options-not-working-2` --- ### 📝 Commits (2) - [`7147adb`](https://github.com/bitwarden/android/commit/7147adb07e6f4b33628c25c222947aa60e08544b) PM-1615 Fix cipher options not working in lists due to binding failing due to type mismatch. Updated GroupingsPageViewModel to new way of calling as well - [`29c537e`](https://github.com/bitwarden/android/commit/29c537e5cbe0c15ea53cb65b754e2256ed991561) Merge branch 'master' into PM-1615-fix-cipher-options-not-working-2 ### 📊 Changes **2 files changed** (+8 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs` (+4 -3) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+4 -10) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix cipher options not working on lists due to binding failing. #2456 again so it gets tested before merged to master ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherViewCell:** Changed type of the `ButtonCommand` from `Command<CipherView>` to `ICommand` to make it more generic and easy to bind to any type of command in the ViewModel. This was causing the issue due to the change on the ViewModel to an `AsyncCommand<...>` * **GroupingsPageViewModel:** Updated to use the `AsyncCommand<...>` as in the other places. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?