github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #210] [CLOSED] AppResources: Rename the English App resources file to use en #2456

New Issue
Closed
opened 2025-11-26 23:19:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:19:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/210
Author: @alistair23
Created: 12/14/2017
Status: ❌ Closed

Base: master ← Head: alistair/appresources

📝 Commits (1)

  • baff8ed AppResources: Rename the English App resources file to use en

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 src/App/App.csproj (+4 -4)
📝 src/App/Resources/AppResources.en.Designer.cs (+0 -0)
📝 src/App/Resources/AppResources.en.resx (+0 -0)

📄 Description

If the English app resource files aren't using the standard language
format we see GetString() returning NULL on UWP. To fix this rename the
files to include the language identifier.

More information here:
https://support.microsoft.com/en-us/help/839861/a-system-resources-missingmanifestresourceexception-exception-occurs-w

Signed-off-by: Alistair Francis alistair@alistair23.me

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/210 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/14/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `alistair/appresources` --- ### 📝 Commits (1) - [`baff8ed`](https://github.com/bitwarden/android/commit/baff8ed773b44dd2a68614171ed33c4360857cd5) AppResources: Rename the English App resources file to use en ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+4 -4) 📝 `src/App/Resources/AppResources.en.Designer.cs` (+0 -0) 📝 `src/App/Resources/AppResources.en.resx` (+0 -0) </details> ### 📄 Description If the English app resource files aren't using the standard language format we see GetString() returning NULL on UWP. To fix this rename the files to include the language identifier. More information here: https://support.microsoft.com/en-us/help/839861/a-system-resources-missingmanifestresourceexception-exception-occurs-w Signed-off-by: Alistair Francis <alistair@alistair23.me> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2456
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?