github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #215] [MERGED] Vault: Don't specify page options for ActivityLoading #2460

New Issue
Closed
opened 2025-11-26 23:19:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:19:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/215
Author: @alistair23
Created: 12/17/2017
Status: ✅ Merged
Merged: 12/18/2017
Merged by: @kspearrin

Base: master ← Head: alistair/loading

📝 Commits (1)

  • 09af9d0 Vault: Don't specify page options for ActivityLoading

📊 Changes

3 files changed (+3 additions, -9 deletions)

View changed files

📝 src/App/Pages/Vault/VaultAutofillListCiphersPage.cs (+1 -3)
📝 src/App/Pages/Vault/VaultListCiphersPage.cs (+1 -3)
📝 src/App/Pages/Vault/VaultListGroupingsPage.cs (+1 -3)

📄 Description

When specifying page options the loader doesn't appear properly on UWP
applications. I also couldn't see the options documented here:
https://developer.xamarin.com/api/type/Xamarin.Forms.ActivityIndicator/

Signed-off-by: Alistair Francis alistair@alistair23.me

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/215 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/17/2017 **Status:** ✅ Merged **Merged:** 12/18/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `alistair/loading` --- ### 📝 Commits (1) - [`09af9d0`](https://github.com/bitwarden/android/commit/09af9d0b0d9d0b22e075c27b68ce1d554628f0eb) Vault: Don't specify page options for ActivityLoading ### 📊 Changes **3 files changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/VaultAutofillListCiphersPage.cs` (+1 -3) 📝 `src/App/Pages/Vault/VaultListCiphersPage.cs` (+1 -3) 📝 `src/App/Pages/Vault/VaultListGroupingsPage.cs` (+1 -3) </details> ### 📄 Description When specifying page options the loader doesn't appear properly on UWP applications. I also couldn't see the options documented here: https://developer.xamarin.com/api/type/Xamarin.Forms.ActivityIndicator/ Signed-off-by: Alistair Francis <alistair@alistair23.me> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?