github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-30 17:33:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3071] [MERGED] [PM-6751]Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator #56758

New Issue
Closed
opened 2026-05-10 19:46:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-10 19:46:53 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3071
Author: @dinisvieira
Created: 3/10/2024
Status: ✅ Merged
Merged: 3/11/2024
Merged by: @fedemkr

Base: main ← Head: bug/crash-using-webauthentication-android

📝 Commits (3)

  • 0f9badd Added missing query intent for CustomTabs that might be responsible for the crashes in WebAuthenticator
  • 3f96499 minor formatting issue on AndroidManifest.xml
  • 5a75335 Fix formatting in AndroidManifest

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/App/Platforms/Android/AndroidManifest.xml (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There's a NullPointerException ocurring in WebAuthenticatorIntermediateActivity.
This is likely related with WebAuthenticatorCallbackActivity in Android.
As explained in the Microsoft Docs when using this WebAuthenticator on Android we need to add the appropriate query.
This might be the cause of the bug.

<queries>
    <intent>
        <action android:name="android.support.customtabs.action.CustomTabsService" />
    </intent>
</queries>

Code changes

Added the query intent for CustomTabs as it might fix the exception that is occurring in Android WebAuthenticator.

  • AndroidManifest.xml: Added the query

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3071 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 3/10/2024 **Status:** ✅ Merged **Merged:** 3/11/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `bug/crash-using-webauthentication-android` --- ### 📝 Commits (3) - [`0f9badd`](https://github.com/bitwarden/android/commit/0f9baddb2b3ae9a1f09cd5013c5bbf87132d9f0e) Added missing query intent for CustomTabs that might be responsible for the crashes in WebAuthenticator - [`3f96499`](https://github.com/bitwarden/android/commit/3f964992fcec12eb8ab967a2c4f2d84f040fbcae) minor formatting issue on AndroidManifest.xml - [`5a75335`](https://github.com/bitwarden/android/commit/5a753350739afde0d275877eff1bef76515ccede) Fix formatting in AndroidManifest ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/AndroidManifest.xml` (+3 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective There's a `NullPointerException` ocurring in `WebAuthenticatorIntermediateActivity`. This is likely related with `WebAuthenticatorCallbackActivity` in Android. As explained in the [Microsoft Docs](https://learn.microsoft.com/en-us/dotnet/maui/platform-integration/communication/authentication?view=net-maui-8.0&tabs=android) when using this WebAuthenticator on Android we need to add the appropriate query. This might be the cause of the bug. ``` <queries> <intent> <action android:name="android.support.customtabs.action.CustomTabsService" /> </intent> </queries> ``` ## Code changes Added the query intent for CustomTabs as it might fix the exception that is occurring in Android WebAuthenticator. * **AndroidManifest.xml:** Added the query ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-10 19:46:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#56758