github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 20:24:12 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1680] [MERGED] remove re-throws of exceptions, hiding stack trace #3051

New Issue
Closed
opened 2025-11-26 23:27:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1680
Author: @jlf0dev
Created: 12/9/2021
Status: ✅ Merged
Merged: 12/16/2021
Merged by: @jlf0dev

Base: master ← Head: tech-debt/remove-exception-rethrows

📝 Commits (4)

  • 07860f2 remove re-throws of exceptions, hiding stack trace
  • 52445d2 revert to catch all ApiExceptions
  • 900cb7e add back throw in auditService
  • 9f20100 whitespace

📊 Changes

4 files changed (+5 additions, -5 deletions)

View changed files

📝 src/Core/Services/AuditService.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+1 -1)
📝 src/Core/Services/CipherService.cs (+1 -1)
📝 src/Core/Services/SendService.cs (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

remove throw e from project as it hides stack trace
https://app.asana.com/0/1153292148278596/1201459506316842/f

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1680 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 12/9/2021 **Status:** ✅ Merged **Merged:** 12/16/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `tech-debt/remove-exception-rethrows` --- ### 📝 Commits (4) - [`07860f2`](https://github.com/bitwarden/android/commit/07860f250ff6405643b0f78cb768196ca95ab84c) remove re-throws of exceptions, hiding stack trace - [`52445d2`](https://github.com/bitwarden/android/commit/52445d209fc8ad7cf71acef1f4f09f0d03553ee9) revert to catch all ApiExceptions - [`900cb7e`](https://github.com/bitwarden/android/commit/900cb7e0db46c7ac83e0bc2109e62511e0d6c691) add back throw in auditService - [`9f20100`](https://github.com/bitwarden/android/commit/9f201009ada6d514b30b284cf6e027f3c6bdf0f7) whitespace ### 📊 Changes **4 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/AuditService.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+1 -1) 📝 `src/Core/Services/CipherService.cs` (+1 -1) 📝 `src/Core/Services/SendService.cs` (+2 -2) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> remove `throw e` from project as it hides stack trace https://app.asana.com/0/1153292148278596/1201459506316842/f ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?