github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3051] [MERGED] [PM-6552] Fix for Android Window issues when opening Autofill/Accessibility #41082

New Issue
Closed
opened 2026-04-23 19:53:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:53:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3051
Author: @dinisvieira
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @dinisvieira

Base: main ← Head: feature/PM-6552-fix-for-launching-app-after-accessibility-settings

📝 Commits (2)

  • bd50681 PM-6552 Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage.
  • 4a2f9ef Update src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs

📊 Changes

4 files changed (+26 additions, -74 deletions)

View changed files

📝 src/Core/App.xaml.cs (+3 -51)
📝 src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs (+23 -8)
📝 src/Core/Pages/Settings/AutofillSettingsPageViewModel.android.cs (+0 -5)
📝 src/Core/ResumeWindow.cs (+0 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There are still several edge cases in which the app should try to execute the navigation after showing the HomePage and doesn't.
As an alternative we are trying to always try to Navigate when CreateWindow is launched on Android.

Code changes

Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage
AndroidNavigationRedirectPage now more resilient to failure and navigates to HomePage as fallback.

  • App.xaml.cs: Removed a lot of the previous workarounds which should now be replaced with just using always AndroidNavigationRedirectPage
  • AndroidNavigationRedirectPage.xaml.cs: Made redirection a bit more resilient and with fallback to just Navigate to HomePage
  • AutofillSettingsPageViewModel.android.cs: Removed previous workaround for Accessibility Settings as it's no longer need
  • ResumeWindow.cs: AutofillWindow and MainWindow is no longer needed as we don't reuse or differentiate anymore

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3051 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@dinisvieira](https://github.com/dinisvieira) **Base:** `main` ← **Head:** `feature/PM-6552-fix-for-launching-app-after-accessibility-settings` --- ### 📝 Commits (2) - [`bd50681`](https://github.com/bitwarden/android/commit/bd50681330d967ec1b77ff2a0cf3da2d6bd548b6) PM-6552 Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage. - [`4a2f9ef`](https://github.com/bitwarden/android/commit/4a2f9efd73df43abeb7a3982ec9ec307c4d943c2) Update src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs ### 📊 Changes **4 files changed** (+26 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/App.xaml.cs` (+3 -51) 📝 `src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs` (+23 -8) 📝 `src/Core/Pages/Settings/AutofillSettingsPageViewModel.android.cs` (+0 -5) 📝 `src/Core/ResumeWindow.cs` (+0 -10) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective There are still several edge cases in which the app should try to execute the navigation after showing the HomePage and doesn't. As an alternative we are trying to always try to Navigate when `CreateWindow` is launched on Android. ## Code changes Removed several of the Window Workarounds for Android. Now always relying on the `AndroidNavigationRedirectPage` `AndroidNavigationRedirectPage` now more resilient to failure and navigates to HomePage as fallback. * **App.xaml.cs:** Removed a lot of the previous workarounds which should now be replaced with just using always `AndroidNavigationRedirectPage` * **AndroidNavigationRedirectPage.xaml.cs:** Made redirection a bit more resilient and with fallback to just Navigate to HomePage * **AutofillSettingsPageViewModel.android.cs:** Removed previous workaround for Accessibility Settings as it's no longer need * **ResumeWindow.cs:** `AutofillWindow` and `MainWindow` is no longer needed as we don't reuse or differentiate anymore ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:53:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41082
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?