github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3051] [PM-6552] Fix for Android Window issues when opening Autofill/Accessibility #3992

New Issue
Closed
opened 2025-11-26 23:39:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:39:21 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/3051

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There are still several edge cases in which the app should try to execute the navigation after showing the HomePage and doesn't.
As an alternative we are trying to always try to Navigate when CreateWindow is launched on Android.

Code changes

Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage
AndroidNavigationRedirectPage now more resilient to failure and navigates to HomePage as fallback.

  • App.xaml.cs: Removed a lot of the previous workarounds which should now be replaced with just using always AndroidNavigationRedirectPage
  • AndroidNavigationRedirectPage.xaml.cs: Made redirection a bit more resilient and with fallback to just Navigate to HomePage
  • AutofillSettingsPageViewModel.android.cs: Removed previous workaround for Accessibility Settings as it's no longer need
  • ResumeWindow.cs: AutofillWindow and MainWindow is no longer needed as we don't reuse or differentiate anymore

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/3051 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective There are still several edge cases in which the app should try to execute the navigation after showing the HomePage and doesn't. As an alternative we are trying to always try to Navigate when `CreateWindow` is launched on Android. ## Code changes Removed several of the Window Workarounds for Android. Now always relying on the `AndroidNavigationRedirectPage` `AndroidNavigationRedirectPage` now more resilient to failure and navigates to HomePage as fallback. * **App.xaml.cs:** Removed a lot of the previous workarounds which should now be replaced with just using always `AndroidNavigationRedirectPage` * **AndroidNavigationRedirectPage.xaml.cs:** Made redirection a bit more resilient and with fallback to just Navigate to HomePage * **AutofillSettingsPageViewModel.android.cs:** Removed previous workaround for Accessibility Settings as it's no longer need * **ResumeWindow.cs:** `AutofillWindow` and `MainWindow` is no longer needed as we don't reuse or differentiate anymore ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:39:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?