github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-19 12:47:49 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3031] [MERGED] [PM-5912] Fix for some iOS buttons not having the correct height and corner radius #29984

New Issue
Closed
opened 2026-04-18 13:50:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:50:47 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3031
Author: @dinisvieira
Created: 2/24/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @fedemkr

Base: main ← Head: feature/PM-5912-ios-buttons-incorrect-styling

📝 Commits (1)

  • 57a851a PM-5912 Added default min height and corner radius for iOS buttons. Also removed incorrect style class from one button.

📊 Changes

2 files changed (+4 additions, -7 deletions)

View changed files

📝 src/Core/Pages/Accounts/LoginPasswordlessPage.xaml (+0 -1)
📝 src/Core/Resources/Styles/iOS.xaml (+4 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Some buttons on iOS don't have the correct Height and Corner Radius

Code changes

Xamarin Forms doesn't seem to have the same defaults for Buttons than MAUI on iOS.
To fix these issues I added default min height and corner radius for iOS buttons.
Also removed incorrect style class from one button.

  • iOS.xaml: Added default CornerRadius and MinHeightRequest for iOS Buttons and removed redundant properties from other Button styles that are based from default one.
  • LoginPasswordlessPage.xaml: Removed incorrect class

Screenshots

Before After
Device_Aprove_Before Device_Aprove_After
Cipher_Add_Edit_Before Cipher_Add_Edit_After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3031 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/24/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `main` ← **Head:** `feature/PM-5912-ios-buttons-incorrect-styling` --- ### 📝 Commits (1) - [`57a851a`](https://github.com/bitwarden/android/commit/57a851a2ed13a4de78865c1f07b3122855747102) PM-5912 Added default min height and corner radius for iOS buttons. Also removed incorrect style class from one button. ### 📊 Changes **2 files changed** (+4 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Accounts/LoginPasswordlessPage.xaml` (+0 -1) 📝 `src/Core/Resources/Styles/iOS.xaml` (+4 -6) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Some buttons on iOS don't have the correct Height and Corner Radius ## Code changes Xamarin Forms doesn't seem to have the same defaults for Buttons than MAUI on iOS. To fix these issues I added default min height and corner radius for iOS buttons. Also removed incorrect style class from one button. * **iOS.xaml:** Added default CornerRadius and MinHeightRequest for iOS Buttons and removed redundant properties from other Button styles that are based from default one. * **LoginPasswordlessPage.xaml:** Removed incorrect class ## Screenshots Before | After :-------------------------:|:-------------------------: <img width="768" alt="Device_Aprove_Before" src="https://github.com/bitwarden/mobile/assets/2824952/c3264a18-f980-4414-b3af-0f8b93879b24"> | <img width="768" alt="Device_Aprove_After" src="https://github.com/bitwarden/mobile/assets/2824952/dc23ea5a-4ac5-488e-97f8-41f89de91d4c"> <img width="768" alt="Cipher_Add_Edit_Before" src="https://github.com/bitwarden/mobile/assets/2824952/505a07fe-262a-4ab0-abcf-d8068cfdc1e7"> | <img width="768" alt="Cipher_Add_Edit_After" src="https://github.com/bitwarden/mobile/assets/2824952/b328fc5f-2c30-493c-8116-f63e7289b2b7"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:50:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29984