github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1231] [CLOSED] CollectionView migration #2802

New Issue
Closed
opened 2025-11-26 23:24:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1231
Author: @mpbw2
Created: 1/21/2021
Status: ❌ Closed

Base: master ← Head: collectionview-conversion

📝 Commits (10+)

📊 Changes

239 files changed (+19101 additions, -3105 deletions)

View changed files

📝 .github/resources/export-options-ad-hoc.plist (+3 -3)
📝 .github/resources/export-options-app-store.plist (+3 -3)
📝 .github/secrets/bitwarden-mobile-key.p12.gpg (+0 -0)
📝 .github/secrets/dist_autofill.mobileprovision.gpg (+0 -0)
📝 .github/secrets/dist_bitwarden.mobileprovision.gpg (+0 -0)
📝 .github/secrets/dist_extension.mobileprovision.gpg (+0 -0)
📝 .github/secrets/iphone-distribution-cert.p12.gpg (+0 -0)
📝 .github/workflows/build.yml (+3 -0)
📝 README.md (+1 -1)
➖ appveyor.yml (+0 -146)
📝 bitwarden-mobile.sln (+66 -1)
📝 src/Android/Accessibility/AccessibilityHelpers.cs (+11 -2)
📝 src/Android/Android.csproj (+14 -21)
📝 src/Android/Autofill/AutofillHelpers.cs (+7 -0)
📝 src/Android/MainActivity.cs (+55 -3)
📝 src/Android/Properties/AndroidManifest.xml (+14 -1)
➖ src/Android/Renderers/CipherViewCellRenderer.cs (+0 -242)
➕ src/Android/Renderers/ExtendedDatePickerRenderer.cs (+50 -0)
➖ src/Android/Renderers/ExtendedListViewRenderer.cs (+0 -29)
➕ src/Android/Renderers/ExtendedTimePickerRenderer.cs (+50 -0)

...and 80 more files

📄 Description

Continuation of #934 (new PR due to age of 934 resulting in a lot of diff noise). Screenshots below show Before (L) & After (R) for iOS & Android. Almost pixel perfect but struggling in some areas, possibly due to changes in dip calculations under the hood.

@cscharf I've been defeated by the same NPE you ran into regarding the menu button within the grid item. Everything I've read about BindingContext tells me the Cipher should be accessible so something (probably obvious) is still afoot.

System.NullReferenceException: Object reference not set to an instance of an object

  at Bit.App.Utilities.AppHelpers.CipherListOptions (Xamarin.Forms.ContentPage page, Bit.Core.Models.View.CipherView cipher) [0x000c6] in /Users/matt/Documents/Work/Companies/Bitwarden/Repos/mobile/src/App/Utilities/AppHelpers.cs:24 

  at Bit.App.Pages.GroupingsPageViewModel.CipherOptionsAsync (Bit.Core.Models.View.CipherView cipher) [0x0004b] in /Users/matt/Documents/Work/Companies/Bitwarden/Repos/mobile/src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs:517

ios

android

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1231 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 1/21/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `collectionview-conversion` --- ### 📝 Commits (10+) - [`68154e9`](https://github.com/bitwarden/android/commit/68154e9bc13aed326767078018a5d23139f0daf4) wip - [`9876cd5`](https://github.com/bitwarden/android/commit/9876cd547ff222982a32b9ccd7ccaecd8dc82b1f) fdroid.. just do it... - [`2bfabfd`](https://github.com/bitwarden/android/commit/2bfabfd83832f90807f5eae53c2f8f4e402b9c03) Revert "fdroid.. just do it..." - [`3bb92d4`](https://github.com/bitwarden/android/commit/3bb92d452ba9647be51459bcc4d06a4a40148e96) bump to 2.8.1 (#1234) - [`1197c10`](https://github.com/bitwarden/android/commit/1197c105924f8eaf122e704d342ea809ed1341ed) bump google publisher dep (#1235) - [`28a1bd5`](https://github.com/bitwarden/android/commit/28a1bd52199022a2571be5534212434cc8063626) temporarily disable throwing on failure (#1236) - [`9d4d098`](https://github.com/bitwarden/android/commit/9d4d09810a48815ec821b23f4c0b8b1807c831b3) revert "temporarily disable throwing on failure" (#1239) - [`10677f3`](https://github.com/bitwarden/android/commit/10677f3705a018d2b72799b882c63da39fe35468) version bump to 2.8.2 (#1240) - [`9b6bf13`](https://github.com/bitwarden/android/commit/9b6bf136f157d4dba43e1af553928c0d7da3683b) Add passphrase generator to iOS Extensions (#1230) - [`8d5614c`](https://github.com/bitwarden/android/commit/8d5614cd7bf915b36fe48649cf9f272a5809c2da) Port send jslib to mobile (#1219) ### 📊 Changes **239 files changed** (+19101 additions, -3105 deletions) <details> <summary>View changed files</summary> 📝 `.github/resources/export-options-ad-hoc.plist` (+3 -3) 📝 `.github/resources/export-options-app-store.plist` (+3 -3) 📝 `.github/secrets/bitwarden-mobile-key.p12.gpg` (+0 -0) 📝 `.github/secrets/dist_autofill.mobileprovision.gpg` (+0 -0) 📝 `.github/secrets/dist_bitwarden.mobileprovision.gpg` (+0 -0) 📝 `.github/secrets/dist_extension.mobileprovision.gpg` (+0 -0) 📝 `.github/secrets/iphone-distribution-cert.p12.gpg` (+0 -0) 📝 `.github/workflows/build.yml` (+3 -0) 📝 `README.md` (+1 -1) ➖ `appveyor.yml` (+0 -146) 📝 `bitwarden-mobile.sln` (+66 -1) 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+11 -2) 📝 `src/Android/Android.csproj` (+14 -21) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+7 -0) 📝 `src/Android/MainActivity.cs` (+55 -3) 📝 `src/Android/Properties/AndroidManifest.xml` (+14 -1) ➖ `src/Android/Renderers/CipherViewCellRenderer.cs` (+0 -242) ➕ `src/Android/Renderers/ExtendedDatePickerRenderer.cs` (+50 -0) ➖ `src/Android/Renderers/ExtendedListViewRenderer.cs` (+0 -29) ➕ `src/Android/Renderers/ExtendedTimePickerRenderer.cs` (+50 -0) _...and 80 more files_ </details> ### 📄 Description Continuation of #934 (new PR due to age of 934 resulting in a lot of diff noise). Screenshots below show Before (L) & After (R) for iOS & Android. _Almost_ pixel perfect but struggling in some areas, possibly due to changes in dip calculations under the hood. @cscharf I've been defeated by the same NPE you ran into regarding the menu button within the grid item. Everything I've read about `BindingContext` tells me the Cipher should be accessible so _something_ (probably obvious) is still afoot. ``` System.NullReferenceException: Object reference not set to an instance of an object at Bit.App.Utilities.AppHelpers.CipherListOptions (Xamarin.Forms.ContentPage page, Bit.Core.Models.View.CipherView cipher) [0x000c6] in /Users/matt/Documents/Work/Companies/Bitwarden/Repos/mobile/src/App/Utilities/AppHelpers.cs:24 at Bit.App.Pages.GroupingsPageViewModel.CipherOptionsAsync (Bit.Core.Models.View.CipherView cipher) [0x0004b] in /Users/matt/Documents/Work/Companies/Bitwarden/Repos/mobile/src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs:517 ``` ![ios](https://user-images.githubusercontent.com/59324545/105389797-48633900-5be6-11eb-8cfc-e3338a2827ee.png) ![android](https://user-images.githubusercontent.com/59324545/105389848-5618be80-5be6-11eb-8cc1-d5901e50b000.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2802
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?