github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 00:09:31 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2713] [MERGED] [PM-3543] [PM-3607] Fix password re-prompt when editing and on autofill. #29771

New Issue
Closed
opened 2026-04-18 13:40:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:40:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2713
Author: @andrebispo5
Created: 8/23/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @andrebispo5

Base: master ← Head: auth/pm-3543-3607/mp-reprompt

📝 Commits (3)

  • 1d47554 [PM-3543] [PM-3507] Fix password re-prompt when editing and on autofill.
  • 82b41fd [PM-3543][PM-3607] Refactor code.
  • 38c2016 [PM-3543] [PM-3607] Remove unnecessary service

📊 Changes

5 files changed (+32 additions, -4 deletions)

View changed files

📝 src/Android/MainApplication.cs (+1 -1)
📝 src/App/Services/MobilePasswordRepromptService.cs (+20 -2)
📝 src/Core/Abstractions/ICryptoService.cs (+1 -0)
📝 src/Core/Services/CryptoService.cs (+9 -0)
📝 src/iOS.Core/Utilities/iOSCoreHelpers.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix 2 bugs on password re-prompt. On autofill and editing a cipher, the app would crash.

Code changes

Update code to use userkey.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2713 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/23/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `auth/pm-3543-3607/mp-reprompt` --- ### 📝 Commits (3) - [`1d47554`](https://github.com/bitwarden/android/commit/1d47554f6da7d16ec4f5dc360b2f3b84a52448c7) [PM-3543] [PM-3507] Fix password re-prompt when editing and on autofill. - [`82b41fd`](https://github.com/bitwarden/android/commit/82b41fdf886927d91892050aebcc9329dca11545) [PM-3543][PM-3607] Refactor code. - [`38c2016`](https://github.com/bitwarden/android/commit/38c2016e7d14c299ea01ae922a7ef01f8c3577ff) [PM-3543] [PM-3607] Remove unnecessary service ### 📊 Changes **5 files changed** (+32 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainApplication.cs` (+1 -1) 📝 `src/App/Services/MobilePasswordRepromptService.cs` (+20 -2) 📝 `src/Core/Abstractions/ICryptoService.cs` (+1 -0) 📝 `src/Core/Services/CryptoService.cs` (+9 -0) 📝 `src/iOS.Core/Utilities/iOSCoreHelpers.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix 2 bugs on password re-prompt. On autofill and editing a cipher, the app would crash. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Update code to use userkey. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:40:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?