github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 06:04:20 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #783] [MERGED] Sanitize Password Length #2586

New Issue
Closed
opened 2025-11-26 23:21:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/783
Author: @vincentsalucci
Created: 3/18/2020
Status: ✅ Merged
Merged: 3/18/2020
Merged by: @vincentsalucci

Base: master ← Head: update-sanitize-length

📝 Commits (3)

📊 Changes

1 file changed (+69 additions, -46 deletions)

View changed files

📝 src/Core/Services/PasswordGenerationService.cs (+69 -46)

📄 Description

Objective

Rearrange the current password generation code in order to update the UI if password length varies based on the selected options. Relates to Web Bug #497

Code Changes

  • PasswordGenerationService.cs: Created SanitizePasswordLength method that can be called with UI changes or for password generation only. Maintains existing workflows but will now properly update the UI if a minimum length condition is met.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/783 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 3/18/2020 **Status:** ✅ Merged **Merged:** 3/18/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `update-sanitize-length` --- ### 📝 Commits (3) - [`f94468e`](https://github.com/bitwarden/android/commit/f94468e7cd3558a9cc3d9fdba54ae8a47eb79b06) Sanitize Password Length - [`2119589`](https://github.com/bitwarden/android/commit/211958920e5807579de7ca6dd17d6290783983bf) Formatting updates - [`aea87d5`](https://github.com/bitwarden/android/commit/aea87d51cee05485647f948ab9fd93bf783f1379) Else if format ### 📊 Changes **1 file changed** (+69 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/PasswordGenerationService.cs` (+69 -46) </details> ### 📄 Description ## Objective > Rearrange the current password generation code in order to update the UI if password length varies based on the selected options. Relates to [Web Bug #497](https://github.com/bitwarden/web/issues/497) ## Code Changes - **PasswordGenerationService.cs**: Created `SanitizePasswordLength` method that can be called with UI changes or for password generation only. Maintains existing workflows but will now properly update the UI if a minimum length condition is met. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?